Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

Issue 2740044: Allow music identifiers in \addlyrics (no need for braces any more) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by Reinhold
Modified:
8 years, 10 months ago
Reviewers:
Valentin Villenave
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow music identifiers in \addlyrics (no need for braces any more) In particular, so far the following did not work: \new Staff { \m \addlyrics \l } Instead, one had to use braces around \m and \l: \new Staff { {\m} \addlyrics {\l} } This patch extends the parser to allow music identifiers, so that no braces are needed any more.

Patch Set 1 : Allow music identifiers in \addlyrics #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A input/regression/newaddlyrics-music-identifiers.ly View 1 chunk +15 lines, -0 lines 1 comment Download
M lily/parser.yy View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Valentin Villenave
8 years, 10 months ago (2010-11-19 20:19:58 UTC) #1
Hi Reinhold,

this patch looks awesome; I can't believe I've missed it!  Thanks to Nathan for
digging it up.

Although it's not my call, I find it pretty harmless and straightforward and I
hope you'll merge it soon.  This will make things easier for a *lot* of new
users!

Cheers,
Valentin.

http://codereview.appspot.com/2740044/diff/4001/input/regression/newaddlyrics...
File input/regression/newaddlyrics-music-identifiers.ly (right):

http://codereview.appspot.com/2740044/diff/4001/input/regression/newaddlyrics...
input/regression/newaddlyrics-music-identifiers.ly:14: % This didn't work so
far:
Do we really need this level of verbosity in the regtest comments? Regardless of
what used not to work in the past, I'd just say "Both syntaxes below should
produce the same result."
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b