Issue 2735046: Returns error, if SetGlobalEngine fails.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2735046: Returns error, if SetGlobalEngine fails. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Peng Huang

Modified:
15 years, 4 months ago

Reviewers:
shawn.p.huang, Yusuke Sato

CC:
satorux

Base URL:
git@github.com:/ibus/ibus.git

Visibility:
Public.

Description

Returns error, if SetGlobalEngine fails. BUG=chromium-os:8453 TEST=manual

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update changes #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	bus/ibusimpl.c	View		5 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM, thanks! I'll pick this change to Chrome OS once R9 branch is cut. I ...

15 years, 4 months ago (2010-11-01 09:25:18 UTC) #2

Peng

I checked the code of master and chromeos. This function is totally different, I can ...

15 years, 4 months ago (2010-11-01 09:30:19 UTC) #3

Yusuke Sato

15 years, 4 months ago (2010-11-01 10:26:46 UTC) #4

On 2010/11/01 09:30:19, Shawn.P.Huang wrote:
> I checked the code of master and chromeos. This function is totally different,
I
> can not use the same patch to fix it.

ok, then, let's just forget about master.

Expand All Messages | Collapse All Messages