Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 2734041: Adding ContainsSampledData XMl Element to Analytics Data Feed and uploading samples

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by api.nickm
Modified:
15 years, 1 month ago
Reviewers:
jcgregorio, erikb
CC:
gdata-python-client-library-contributors_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : 'updating the data_feed_sample.py' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M samples/analytics/data_feed_demo.py View 1 3 chunks +8 lines, -6 lines 0 comments Download
M src/gdata/analytics/data.py View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/gdata/test_data.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/gdata_tests/analytics/data_test.py View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6
api.nickm
15 years, 2 months ago (2010-10-26 00:17:20 UTC) #1
erikb
Looks good to me
15 years, 2 months ago (2010-10-26 00:54:15 UTC) #2
erikb
Looks good to me http://codereview.appspot.com/2734041/diff/1/src/gdata/test_data.py File src/gdata/test_data.py (right): http://codereview.appspot.com/2734041/diff/1/src/gdata/test_data.py#newcode5380 src/gdata/test_data.py:5380: <dxp:containsSampledData>true</dxp:containsSampledData> If this test should ...
15 years, 2 months ago (2010-10-26 00:54:47 UTC) #3
api.nickm
15 years, 1 month ago (2010-11-15 07:51:26 UTC) #4
jcgregorio
You got an LGTM, is there a reason this hasn't been committed?
15 years, 1 month ago (2010-11-17 19:04:31 UTC) #5
api.nickm
15 years, 1 month ago (2010-11-17 20:00:15 UTC) #6
On 2010/11/17 19:04:31, jcgregorio wrote:
> You got an LGTM, is there a reason this hasn't been committed?

It's done. Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b