Issue 2734041: Adding ContainsSampledData XMl Element to Analytics Data Feed and uploading samples

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2734041: Adding ContainsSampledData XMl Element to Analytics Data Feed and uploading samples

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by api.nickm

Modified:
15 years, 1 month ago

Reviewers:
jcgregorio, erikb

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 2 : 'updating the data_feed_sample.py' #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -9 lines)			Patch
M	samples/analytics/data_feed_demo.py	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	src/gdata/analytics/data.py	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/gdata/test_data.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/gdata_tests/analytics/data_test.py	View		3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

erikb

Looks good to me http://codereview.appspot.com/2734041/diff/1/src/gdata/test_data.py File src/gdata/test_data.py (right): http://codereview.appspot.com/2734041/diff/1/src/gdata/test_data.py#newcode5380 src/gdata/test_data.py:5380: <dxp:containsSampledData>true</dxp:containsSampledData> If this test should ...

15 years, 2 months ago (2010-10-26 00:54:47 UTC) #3

jcgregorio

You got an LGTM, is there a reason this hasn't been committed?

15 years, 1 month ago (2010-11-17 19:04:31 UTC) #5

api.nickm

15 years, 1 month ago (2010-11-17 20:00:15 UTC) #6

On 2010/11/17 19:04:31, jcgregorio wrote:
> You got an LGTM, is there a reason this hasn't been committed?

It's done. Thanks!

Expand All Messages | Collapse All Messages