Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(230)

Issue 2726041: code review 2726041: 5c: implement uint32 -> float (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by rsc
Modified:
15 years, 4 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

5c: implement uint32 -> float There are other missing conversion cases still but they do not show up in my tests. This one is needed for vlrt.c's _v2d (int64, uint64 -> float). Thankfully, VFP has a single instruction to do this.

Patch Set 1 #

Patch Set 2 : code review 2726041: 5c: implement uint32 -> float #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M src/cmd/5c/txt.c View 6 chunks +40 lines, -11 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 4 months ago (2010-10-25 23:18:14 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=ec64d61e8c1a *** 5c: implement uint32 -> float There are other missing conversion ...
15 years, 4 months ago (2010-10-25 23:18:22 UTC) #2
ken3
15 years, 4 months ago (2010-10-26 04:46:47 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b