Issue 2724041: Use BasicContainerConfig in tests instead of AbstractContainerConfig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2724041: Use BasicContainerConfig in tests instead of AbstractContainerConfig

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by jtarrio

Modified:
15 years, 5 months ago

Reviewers:
johnfargo, zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Use actual container configurations in actual BasicContainerConfig objects instead of mocks and fake container configurations, wherever possible. There's a couple of fake configs left, they are probably not worth spending the work of removing them.

Patch Set 1 #

Patch Set 2 : Incorporate John's comments to my previous patch, update tests #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -339 lines)			Patch
java/common/src/main/java/org/apache/shindig/config/AbstractContainerConfig.java	View	1	1 chunk	+0 lines, -90 lines	0 comments	Download
java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java	View		10 chunks	+60 lines, -65 lines	0 comments	Download
java/common/src/main/java/org/apache/shindig/config/ExpressionContainerConfig.java	View		5 chunks	+7 lines, -9 lines	0 comments	Download
java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java	View	1	5 chunks	+27 lines, -39 lines	0 comments	Download
java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenCodecTest.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizerTest.java	View	1	3 chunks	+15 lines, -31 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ConcatVisitorTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ContentTypeCharsetRemoverRewriterTest.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriterTest.java	View	1	4 chunks	+19 lines, -30 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DomWalkerTest.java	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DomWalkerTestBase.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ImageAttributeRewriterTest.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagExtractorVisitorTest.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java	View	1	4 chunks	+9 lines, -31 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManagerTest.java	View	1	2 chunks	+15 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jtarrio

Incorporate John's comments to my previous patch, update tests

15 years, 5 months ago (2010-10-26 22:53:38 UTC) #2

johnfargo

15 years, 5 months ago (2010-10-27 00:01:12 UTC) #3

LGTM, committed as r1027778. Thanks!

On 2010/10/26 22:53:38, jtarrio wrote:
> Incorporate John's comments to my previous patch, update tests

Expand All Messages | Collapse All Messages