Issue 272150043: fix unwanted capo indication in fret diagrams

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 272150043: fix unwanted capo indication in fret diagrams (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 5 months ago by thomasmorley651

Modified:
8 years, 5 months ago

Reviewers:
pl_s

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

fix unwanted capo indication in fret diagrams issue 4644 Adding a condition to do 1+ for capo-fret only if open strings are absent and capo-fret is not zero

Patch Set 1 #

Patch Set 2 : fix failed make check, clean up #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	scm/fret-diagrams.scm	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

pl_s

8 years, 5 months ago (2015-10-27 17:19:53 UTC) #3

On 2015/10/26 21:47:14, thomasmorley651 wrote:
> fix failed make check, clean up

LGTM.

Expand All Messages | Collapse All Messages