Avoid schema resolution for type=url gadget

[zhoresh, 2010-10-25 22:30:18]

http://codereview.appspot.com/2714041/diff/4001/java/gadgets/src/main/java/or...
File java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java
(right):

http://codereview.appspot.com/2714041/diff/4001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java:163: href =
base.resolve(href);
I can imagine cases were someone depend on this being resolved for path and host
even for type url.
Maybe just remove schema after resolving if not specified in original.

[mhermanto, 2010-10-25 23:21:12]

Good thought. Per code base read in Google, I see 2 cases that'd benefit
from resolving url with authority and gadget path. The rest (~125) of them
are absolute URL. John, thoughts? I start to think that perhaps, we should
do this on a more targetted level within Google. I don't know enough of
usage of type=url gadgets.


On Mon, Oct 25, 2010 at 3:30 PM, <zhoresh@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/2714041/diff/4001/java/gadgets/src/main/java/or...
> File
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java
> (right):
>
>
>
http://codereview.appspot.com/2714041/diff/4001/java/gadgets/src/main/java/or...
> java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java:163:
> href = base.resolve(href);
> I can imagine cases were someone depend on this being resolved for path
> and host even for type url.
> Maybe just remove schema after resolving if not specified in original.
>
>
> http://codereview.appspot.com/2714041/
>

[fargo, 2010-10-25 23:45:39]

Hard to say -- the spec doesn't say anything about this one way or the other:
"Type URL
Type URL gadgets only specify a base URL. A standard set of parameters are added
to this URL by the gadget server..."

A more targeted fix internally is fine, but I actually like Ziv's suggestion
best (drop schema when original doesn't have it either).

On 2010/10/25 23:21:12, mhermanto wrote:
> Good thought. Per code base read in Google, I see 2 cases that'd benefit
> from resolving url with authority and gadget path. The rest (~125) of them
> are absolute URL. John, thoughts? I start to think that perhaps, we should
> do this on a more targetted level within Google. I don't know enough of
> usage of type=url gadgets.
> 
> 
> On Mon, Oct 25, 2010 at 3:30 PM, <mailto:zhoresh@gmail.com> wrote:
> 
> >
> >
> >
>
http://codereview.appspot.com/2714041/diff/4001/java/gadgets/src/main/java/or...
> > File
> >
> > java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java
> > (right):
> >
> >
> >
>
http://codereview.appspot.com/2714041/diff/4001/java/gadgets/src/main/java/or...
> > java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java:163:
> > href = base.resolve(href);
> > I can imagine cases were someone depend on this being resolved for path
> > and host even for type url.
> > Maybe just remove schema after resolving if not specified in original.
> >
> >
> > http://codereview.appspot.com/2714041/
> >

[mhermanto, 2010-10-26 00:00:34]

Update patch

[fargo, 2010-10-26 00:02:09]

LGTM

Add a quick comment for rationale ie. "Facilitates type=url support of
dual-schema endpoints."


On 2010/10/26 00:00:34, mhermanto wrote:
> Update patch

[mhermanto, 2010-10-26 00:03:12]

Done.
On 2010/10/26 00:02:09, fargo wrote:
> LGTM
> 
> Add a quick comment for rationale ie. "Facilitates type=url support of
> dual-schema endpoints."
> 
> 
> On 2010/10/26 00:00:34, mhermanto wrote:
> > Update patch

[zhoresh, 2010-10-28 16:38:42]

LGTM

+1 on a comment that explains the logic