code review 27110043: go.net/html/charset: new package

html/charset/encoding_test.go

 package charset
 
 import (
         "io/ioutil"
         "strings"
         "testing"
 
         "code.google.com/p/go.text/transform"
 )
 
@@ skipping 46 matching lines @@
         {"ｲｳｴｵｶ", "\xb2\xb3\xb4\xb5\xb6", "SJIS"},
         {"これは漢字です。", "\xa4\xb3\xa4\xec\xa4\u03f4\xc1\xbb\xfa\xa4\u01e4\xb9\xa1\xa3", "EUC-JP"},
         {"Hello, 世界!", "Hello, \x1b$B@$3&\x1b(B!", "ISO-2022-JP"},
         {"네이트 | 즐거움의 시작, 슈파스(Spaβ) NATE", "\xb3\xd7\xc0\xcc\xc6\xae | \xc1\xf1\xb0\xc5\xbf\xf2\xc0\xc7 \xbd\xc3\xc0\xdb, \xbd\xb4\xc6\xc4\xbd\xba(Spa\xa5\xe2) NATE", "EUC-KR"},
 }
 
 func TestDecode(t *testing.T) {
         for _, tc := range testCases {
                 e := Encoding(tc.otherEncoding)
                 if e == nil {
-                        t.Errorf("Could not create decoder for %s", tc.otherEncoding)

[nigeltao, 2013/11/18 04:16:18]

I would make these error messages consistently be prefixed by tc.otherEncoding:

t.Errorf("%s: not found", tc.otherEncoding)

and below:

t.Errorf("%s: decode %q: %v", tc.otherEncoding, tc.other, err)

[andybalholm, 2013/11/18 17:01:28]

Done.

+                        t.Errorf("%s: not found", tc.otherEncoding)
                         continue
                 }
 
                 s, err := transformString(e.NewDecoder(), tc.other)
 
                 if err != nil {
-                        t.Errorf("error decoding %q from %s: %s", tc.other, tc.otherEncoding, err)
+                        t.Errorf("%s: decode %q: %v", tc.otherEncoding, tc.other, err)
                         continue
                 }
 
                 if s != tc.utf8 {
                         t.Errorf("%s: got %q, want %q", tc.otherEncoding, s, tc.utf8)
                 }
         }
 }
 
 func TestEncode(t *testing.T) {
         for _, tc := range testCases {
                 e := Encoding(tc.otherEncoding)
                 if e == nil {
-                        t.Errorf("Could not create encoder for %s", tc.otherEncoding)
+                        t.Errorf("%s: not found", tc.otherEncoding)
                         continue
                 }
 
                 s, err := transformString(e.NewEncoder(), tc.utf8)
 
                 if err != nil {
-                        t.Errorf("error encoding %q to %s: %s", tc.utf8, tc.otherEncoding, err)
+                        t.Errorf("%s: encode %q: %s", tc.otherEncoding, tc.utf8, err)
                         continue
                 }
 
                 if s != tc.other {
                         t.Errorf("%s: got %q, want %q", tc.otherEncoding, s, tc.other)
                 }
         }
 }