Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 27100: Minimize dependencies to NekoSerializer

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by cnwan
Modified:
16 years, 11 months ago
Reviewers:
louiscryan
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Since I am going to provide another favour of HtmlSerializer, namely NekoCompactSerializer, I would like to let user to choose which serializer to use. In order to make that happen, I did the following: 1. Utility methods that are common to all HTML serialization are moved to HtmlSerializer. 2. GadgetHtmlParser subclasses no longer attach HtmlSerializer themselves during parseDomImpl. Instead, they implement a template method createSerializer. This further strengthen the contract between GadgetHtmlParser and HtmlSerializer.

Patch Set 1 #

Patch Set 2 : repositioned to java/... instead of trunk/... #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -48 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java View 2 chunks +9 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/HtmlSerializer.java View 5 chunks +17 lines, -3 lines 1 comment Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoHtmlParser.java View 1 chunk +5 lines, -3 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoSerializer.java View 7 chunks +8 lines, -31 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoSimplifiedHtmlParser.java View 2 chunks +4 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/AbstractTagHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/HtmlTagHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/nekohtml/SocialMarkupHtmlParserTest.java View 2 chunks +2 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RenderTagHandlerTest.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateBasedTagHandlerTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
cnwan
16 years, 11 months ago (2009-03-24 08:43:10 UTC) #1
cnwan
repositioned to java/... instead of trunk/...
16 years, 11 months ago (2009-03-24 10:45:05 UTC) #2
louiscryan
16 years, 11 months ago (2009-03-24 16:37:10 UTC) #3
Looks fine to me.

http://codereview.appspot.com/27100/diff/1002/1011
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/HtmlSerializer.java
(right):

http://codereview.appspot.com/27100/diff/1002/1011#newcode110
Line 110: public static void printEscapedText(CharSequence text, Appendable
output) throws IOException {
FYI - We will likely be switching the serializer to use the one in Caja with the
next Caja syncup so this may not be needed. Fine for now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b