Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 270690043: Hiding the snprintf definition when building with VS2015. https://code.google.com/p/webrtc/issues/d… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by conceptgenesis
Modified:
9 years, 3 months ago
Reviewers:
kjellander1
Base URL:
https://chromium.googlesource.com/external/gflags/src@master
Visibility:
Public.

Description

Hiding the snprintf definition when building with VS2015. https://code.google.com/p/webrtc/issues/detail?id=5183&thanks=5183&ts=1446960551 Added test for VisualStudio to hide snprintf definition, This is required to build WebRtc on Windows with Visual Studio 2015. BUG=127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M windows/port.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
conceptgenesis
This is my first contribution to Google (or anything OpenSource frankly). So please educate me ...
9 years, 4 months ago (2015-11-08 05:52:16 UTC) #1
kjellander1
9 years, 4 months ago (2015-11-09 05:41:25 UTC) #2
Thanks for offering your help here! Unfortunately the gflags we have in WebRTC
is quite old, and the code location you're trying to update is a read-only
mirror of what gflags code used to live at Google Code.

The gflags project has moved to Github and the change you're trying to make is
already present upstream:
https://github.com/gflags/gflags/blob/master/src/windows_port.cc

I've created https://code.google.com/p/webrtc/issues/detail?id=5185 for bringing
the latest gflags into WebRTC.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b