code review 2701041: build: only print "You need to add foo to PATH" when needed

build: only print "You need to add foo to PATH" when needed

Fixes issue 1223.

[adg, 2010-10-25 05:26:07]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[dangabrad, 2010-10-25 05:36:11]

LGTM
 On Oct 24, 2010 10:26 PM, <adg@golang.org> wrote:
> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> build: only print "You need to add foo to PATH" when needed
>
> Please review this at http://codereview.appspot.com/2701041/
>
> Affected files:
> M src/make.bash
>
>
> Index: src/make.bash
> ===================================================================
> --- a/src/make.bash
> +++ b/src/make.bash
> @@ -96,7 +96,7 @@
> echo Installed Go for $GOOS/$GOARCH in "$GOROOT".
> echo Installed commands in "$GOBIN".
> case "$OLDPATH" in
> - *":$GOBIN" | *":$GOBIN:"*)
> + "$GOBIN:"* | *":$GOBIN" | *":$GOBIN:"*)
> ;;
> *)
> echo '***' "You need to add $GOBIN to your "'$PATH.' '***'
>
>

[adg, 2010-10-25 05:39:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=b4a830419384 ***

build: only print "You need to add foo to PATH" when needed

Fixes issue 1223.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/2701041