Issue 269930043: Bug 1210380 - Code can never be reached because of a logical contradiction in ssl3_HandleServerName…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 269930043: Bug 1210380 - Code can never be reached because of a logical contradiction in ssl3_HandleServerName… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 7 months ago by ttaubert

Modified:
8 years, 5 months ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1210380 - Code can never be reached because of a logical contradiction in ssl3_HandleServerName…

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	lib/ssl/ssl3ext.c	View		1 chunk	+0 lines, -3 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ekr-rietveld

https://codereview.appspot.com/269930043/diff/1/lib/ssl/ssl3ext.c File lib/ssl/ssl3ext.c (left): https://codereview.appspot.com/269930043/diff/1/lib/ssl/ssl3ext.c#oldcode455 lib/ssl/ssl3ext.c:455: if (!listCount) { In line 429, if listLenBytes == ...

8 years, 7 months ago (2015-10-01 13:43:57 UTC) #1

8 years, 7 months ago (2015-10-01 18:09:10 UTC) #2

https://codereview.appspot.com/269930043/diff/1/lib/ssl/ssl3ext.c
File lib/ssl/ssl3ext.c (left):

https://codereview.appspot.com/269930043/diff/1/lib/ssl/ssl3ext.c#oldcode455
lib/ssl/ssl3ext.c:455: if (!listCount) {
On 2015/10/01 13:43:57, ekr-webrtc wrote:
> This seems to imply that in line 430, we should be returning SECFailure and
> arguably calling ssl3_DecodeError()

Let's just fix this bug. See 1210484

Expand All Messages | Collapse All Messages