Issue 26940043: Backport the goyaml naked dash fix.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26940043: Backport the goyaml naked dash fix.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by curtis

Modified:
11 years, 7 months ago

Reviewers:
mp+195410, rog

Visibility:
Public.

Description

Backport the goyaml naked dash fix. Update dependencies.tsv to get the latest version of goyaml which fixes the naked dash problem. I verified this fix by running: godeps -u dependencies.tsv https://code.launchpad.net/~sinzui/juju-core/goyaml-dash-fix/+merge/195410 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	dependencies.tsv	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rog

11 years, 7 months ago (2013-11-15 16:01:09 UTC) #2

On 2013/11/15 15:49:16, curtis wrote:
> Please take a look.

LGTM except i think it should probably use rev 50, not 49.

Thanks for making sure it works.

We should probably add a test case to trunk,
but that can happen later.

Expand All Messages | Collapse All Messages