Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4410)

Issue 2692041: Add pyviz module

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by gjcarneiro
Modified:
10 years, 7 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated patch #

Total comments: 4

Patch Set 3 : this patch describing message field sucks #

Patch Set 4 : added --visualize option for waf --run/pyrun #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5474 lines, -7 lines) Patch
M doc/doxygen.conf View 1 chunk +3 lines, -1 line 0 comments Download
A src/tools/visualizer/doc/readme.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A src/tools/visualizer/examples/readme.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A src/tools/visualizer/model/pyviz.h View 2 1 chunk +225 lines, -0 lines 0 comments Download
A src/tools/visualizer/model/pyviz.cc View 2 1 chunk +1406 lines, -0 lines 0 comments Download
A src/tools/visualizer/model/visual-simulator-impl.h View 2 1 chunk +82 lines, -0 lines 0 comments Download
A src/tools/visualizer/model/visual-simulator-impl.cc View 2 1 chunk +228 lines, -0 lines 0 comments Download
A src/tools/visualizer/model/visualizer-ideas.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/base.py View 1 chunk +107 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/core.py View 2 1 chunk +1470 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/higcontainer.py View 1 chunk +97 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/hud.py View 1 chunk +144 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/ipython_view.py View 1 chunk +296 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/plugins/interface_statistics.py View 1 chunk +167 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/plugins/ipv4_routing_table.py View 1 chunk +95 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/plugins/olsr.py View 1 chunk +102 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/plugins/show_last_packets.py View 1 chunk +231 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/plugins/wifi_intrastructure_link.py View 1 chunk +117 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/resource/Basurero_Palm_Z22.svg View 1 chunk +311 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/resource/adriankierman_cell_phone_tower.svg View 1 chunk +38 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/resource/bobocal_Yellow_Bus.svg View 1 chunk +39 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/resource/thilakarathna_Bus_Halt.svg View 1 chunk +90 lines, -0 lines 0 comments Download
A src/tools/visualizer/visualizer/svgitem.py View 1 chunk +156 lines, -0 lines 0 comments Download
A src/tools/visualizer/wscript View 1 chunk +22 lines, -0 lines 0 comments Download
M src/wscript View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M wscript View 2 chunks +7 lines, -2 lines 0 comments Download
M wutils.py View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 20
Tom Henderson
+1 to add to ns-3 main tree; I frequently use pyviz. I added to the ...
10 years, 9 months ago (2010-10-24 02:18:33 UTC) #1
gjcarneiro
On 2010/10/24 02:18:33, Tom Henderson wrote: > +1 to add to ns-3 main tree; I ...
10 years, 9 months ago (2010-10-25 10:31:25 UTC) #2
Tom Henderson
On 2010/10/25 10:31:25, gjcarneiro wro > > I am still not very sure about what ...
10 years, 9 months ago (2010-10-25 14:08:34 UTC) #3
gjcarneiro
On 2010/10/25 14:08:34, Tom Henderson wrote: > On 2010/10/25 10:31:25, gjcarneiro wro > > > ...
10 years, 9 months ago (2010-10-25 15:06:44 UTC) #4
Tom Henderson
+1 for prioritizing this for merge soon there need to be some top-level confchecks in ...
10 years, 8 months ago (2010-11-05 03:07:02 UTC) #5
Tom Henderson
> > One comment I had was about documentation/examples for how to use plugins, > ...
10 years, 8 months ago (2010-11-05 03:09:06 UTC) #6
gjcarneiro
http://codereview.appspot.com/2692041/diff/1/examples/wireless/wifi-simple-adhoc-grid.cc File examples/wireless/wifi-simple-adhoc-grid.cc (right): http://codereview.appspot.com/2692041/diff/1/examples/wireless/wifi-simple-adhoc-grid.cc#newcode241 examples/wireless/wifi-simple-adhoc-grid.cc:241: Visualizer::Run (); On 2010/11/05 03:07:02, Tom Henderson wrote: > ...
10 years, 8 months ago (2010-11-05 14:47:26 UTC) #7
gjcarneiro
On 2010/11/05 03:07:02, Tom Henderson wrote: > +1 for prioritizing this for merge soon > ...
10 years, 8 months ago (2010-11-15 11:53:50 UTC) #8
gjcarneiro
The new patch set (2) changes the following: 1. There's no more Visualizer class, visualizer ...
10 years, 8 months ago (2010-11-15 12:37:42 UTC) #9
Tom Henderson
On 2010/11/15 12:37:42, gjcarneiro wrote: > The new patch set (2) changes the following: > ...
10 years, 8 months ago (2010-11-17 22:25:29 UTC) #10
Tom Henderson
I also tried this code on several examples and noticed that it didn't launch a ...
10 years, 8 months ago (2010-11-17 22:27:03 UTC) #11
gjcarneiro
On 2010/11/17 22:25:29, Tom Henderson wrote: > On 2010/11/15 12:37:42, gjcarneiro wrote: > > The ...
10 years, 8 months ago (2010-11-17 23:59:23 UTC) #12
gjcarneiro
On 2010/11/17 22:27:03, Tom Henderson wrote: > I also tried this code on several examples ...
10 years, 8 months ago (2010-11-18 00:00:24 UTC) #13
Mathieu Lacage
I did not have time to go through a lot of code but it all ...
10 years, 8 months ago (2010-11-18 08:23:13 UTC) #14
gjcarneiro
On 2010/11/18 08:23:13, Mathieu Lacage wrote: > I did not have time to go through ...
10 years, 8 months ago (2010-11-18 10:52:52 UTC) #15
gjcarneiro
1. add ObjectFactory; 2. don't use Simulator::RunOne (at the cost of not knowing when the ...
10 years, 8 months ago (2010-11-21 22:37:54 UTC) #16
Tom Henderson
> 3. add one line doxygen comments stating the pyviz APIs are internal, add them ...
10 years, 8 months ago (2010-11-22 04:59:02 UTC) #17
Mathieu Lacage
On 2010/11/18 10:52:52, gjcarneiro wrote: > > I really don't understand why you can't call ...
10 years, 8 months ago (2010-11-22 19:37:41 UTC) #18
gjcarneiro
On 2010/11/22 19:37:41, Mathieu Lacage wrote: > On 2010/11/18 10:52:52, gjcarneiro wrote: > > > ...
10 years, 8 months ago (2010-11-22 19:55:47 UTC) #19
gjcarneiro
10 years, 7 months ago (2010-12-06 18:00:20 UTC) #20
Merged!

changeset:   6676:8a57344a8d09
user:        Gustavo J. A. M. Carneiro  <gjc@inescporto.pt>
date:        Mon Dec 06 17:26:06 2010 +0000
summary:     Codereview Issue 2692041: Add pyviz module

changeset:   6677:06864ef8c0a1
tag:         tip
user:        Gustavo J. A. M. Carneiro  <gjc@inescporto.pt>
date:        Mon Dec 06 17:59:20 2010 +0000
summary:     Python bindings rescan for pyviz
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b