Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(385)

Issue 265370043: Support slurs starting and/or ending on individual notes in chords (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by dak
Modified:
8 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Support slurs starting and/or ending on individual notes in chords Sorry, I can't actually come up with satisfactory examples right now. Please find something in Chopin or so. I'm sure we discussed this on the mailing list at some point of time. Also contains commits: Accept note heads as slur bounds Also changes base_attachment calculation for in-chord slurs. Move in-chord slur info to slur boundaries Listen to and record in-chord slurs Add event_symbol function to all slur engravers Rename Slur_proto_engraver::internal_listen_slur to listen_slur That's more in line with how we divert to base class functions elsewhere.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -29 lines) Patch
M lily/include/slur-proto-engraver.hh View 4 chunks +17 lines, -5 lines 0 comments Download
M lily/phrasing-slur-engraver.cc View 2 chunks +17 lines, -1 line 0 comments Download
M lily/slur-engraver.cc View 2 chunks +17 lines, -1 line 0 comments Download
M lily/slur-proto-engraver.cc View 10 chunks +68 lines, -15 lines 0 comments Download
M lily/slur-scoring.cc View 5 chunks +26 lines, -7 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b