Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 265160043: Issue 4600: Let notes/rests suppress multi-measure rest grobs

Can't Edit
Can't Publish+Mail
Start Review
3 years, 10 months ago by Dan Eble
3 years, 10 months ago


NOTE: Patch set 1 covers changes already in review. Please start this review with patch set 2. As the part combiner shuffles musical content between Voice contexts, it can place notes and rests in a Voice with an ongoing multi-measure rest. The part combiner currently addresses this by killing multi-measure rests at certain times; a major shortcoming of which is that once a rest is killed, it can never reappear. This enhancement to the Multi_measure_rest_engraver will allow future changes to the part combiner which kill multi-measure rests less often (hopefully never). (I have already started other improvements; this is not purely conjecture.) I am submitting this change for testing and review on its own so that there is a clear record of its impact, which should be "no visible difference."

Patch Set 1 : Issue 4594 (https://codereview.appspot.com/268740044/) #

Patch Set 2 : Let notes/rests suppress mmrest grobs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -143 lines) Patch
M lily/multi-measure-rest-engraver.cc View 1 4 chunks +163 lines, -143 lines 0 comments Download


Total messages: 2
Dan Eble
Let notes/rests suppress mmrest grobs
3 years, 10 months ago (2015-09-12 15:49:20 UTC) #1
Dan Eble
3 years, 10 months ago (2015-09-12 15:57:28 UTC) #2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b