Setting return-original-content-on-error for accel container

Setting returnOriginalContentOnError true for accel container so that ProxyHandler does not throw exceptions and returns original content.

When using VanillaCajaHtmlParser, we see the following exception on some pages:

org.apache.shindig.gadgets.rewrite.RewritingException: content.getDocument is null.
Content:

org.apache.shindig.gadgets.rewrite.DomWalker$Rewriter.rewrite(DomWalker.java:162)
org.apache.shindig.gadgets.rewrite.DomWalker$Rewriter.rewrite(DomWalker.java:151)
org.apache.shindig.gadgets.rewrite.DefaultResponseRewriterRegistry.rewriteHttpResponse(DefaultResponseRewriterRegistry.java:55)
org.apache.shindig.gadgets.servlet.ProxyHandler.doFetch(ProxyHandler.java:133)
org.apache.shindig.gadgets.servlet.ProxyBase.fetch(ProxyBase.java:165)
org.apache.shindig.gadgets.servlet.ProxyServlet.doGet(ProxyServlet.java:60)
javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

[anupama.dutta, 2010-10-21 16:17:28]

Could we add some tests for this change?

http://codereview.appspot.com/2646041/diff/4001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
(right):

http://codereview.appspot.com/2646041/diff/4001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:67:
if (gadget.getContext().getContainer().equals(AccelUriManager.CONTAINER)) {
Could any of gadget or gadget.getContext() or gadget.getContext().getContainer()
be null at this point?

http://codereview.appspot.com/2646041/diff/4001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:76:
if (container.equals(AccelUriManager.CONTAINER)) {
Could container be passed as null here?

[gagan.goku, 2010-10-21 20:25:27]

Added tests

http://codereview.appspot.com/2646041/diff/4001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
(right):

http://codereview.appspot.com/2646041/diff/4001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:67:
if (gadget.getContext().getContainer().equals(AccelUriManager.CONTAINER)) {
On 2010/10/21 16:17:28, anupama.dutta wrote:
> Could any of gadget or gadget.getContext() or
gadget.getContext().getContainer()
> be null at this point?

We'r really doomed if some1 passes gadget as null.
gadget.getContext() is anyways called in the parent class constructor, so no
need to worry there as well
gadget.getContext().getContainer() could be null, so refactoring as:
AccelUriManager.CONTAINER.equals(gadget.getContext().getContainer())

should fix it.

http://codereview.appspot.com/2646041/diff/4001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:76:
if (container.equals(AccelUriManager.CONTAINER)) {
On 2010/10/21 16:17:28, anupama.dutta wrote:
> Could container be passed as null here?

It really should not be, but refactored to 
AccelUriManager.CONTAINER.equals(container)

anyways, just to be safe.

[anupama.dutta, 2010-10-26 12:42:24]

LGTM. Please send out on dev for further review.

[plindner1, 2010-10-26 16:05:05]

lgtm

[plindner1, 2010-10-27 05:20:37]

lgtm++

[gagan.goku, 2010-10-27 06:14:11]

Thanks Paul.

Fixed DefaultAccelUriManagerTest.java in this patch as i had missed out the
small change.
Build looks nice now.
Committed as r1027824.