Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 264190043: Fixed a bug where Linux task address spaces wouldn't inherit the profile. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Jordi
Modified:
10 years, 2 months ago
Reviewers:
scudette
CC:
rekall-dev_googlegroups.com
Base URL:
https://github.com/google/rekall.git@master
Visibility:
Public.

Description

Fixed a bug where Linux task address spaces wouldn't inherit the profile. Fixed a bug where get_available_addresses in the XEN AS would return MFNs, breaking plugins that depend on it, like memdump. Fixed an issue where phys_addr in Linux profiles would return negative values. BUG= R=scudette@gmail.com Committed: 4cdeec0bb7c04e0d6fa65cc66c608a89980a80c8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Fixed an issue where phys_addr in Linux profiles would return negative values. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M rekall-core/rekall/addrspace.py View 1 chunk +1 line, -1 line 0 comments Download
M rekall-core/rekall/plugins/addrspaces/amd64.py View 1 2 3 4 6 chunks +39 lines, -10 lines 0 comments Download
M rekall-core/rekall/plugins/overlays/linux/linux.py View 1 2 3 4 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8
Jordi
10 years, 2 months ago (2015-09-08 23:25:24 UTC) #1
Jordi
https://codereview.appspot.com/264190043/diff/60001/rekall-core/rekall/plugins/addrspaces/amd64.py File rekall-core/rekall/plugins/addrspaces/amd64.py (right): https://codereview.appspot.com/264190043/diff/60001/rekall-core/rekall/plugins/addrspaces/amd64.py#newcode400 rekall-core/rekall/plugins/addrspaces/amd64.py:400: p2m_top_location = self.session.profile.get_constant_object( I've been looking into changing this ...
10 years, 2 months ago (2015-09-09 00:07:51 UTC) #2
Jordi
To not delay the release any longer, I'm happy to submit these bugfixes now and ...
10 years, 2 months ago (2015-09-09 05:51:33 UTC) #3
scudette
Lgtm. Awesome! Am 09.09.2015 07:51 schrieb <parki.san@gmail.com>: > To not delay the release any longer, ...
10 years, 2 months ago (2015-09-09 07:59:48 UTC) #4
Jordi
I've added an additional small fix (that doesn't currently affect any piece of real code) ...
10 years, 2 months ago (2015-09-09 15:31:37 UTC) #5
Jordi
I've added an additional small fix (that doesn't currently affect any piece of real code) ...
10 years, 2 months ago (2015-09-09 15:31:38 UTC) #6
scudette
LGTM
10 years, 2 months ago (2015-09-09 15:36:30 UTC) #7
Jordi
10 years, 2 months ago (2015-09-09 15:38:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:70001) manually as
4cdeec0bb7c04e0d6fa65cc66c608a89980a80c8 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b