Issue 2638041: code review 2638041: arm: prop up software floating point

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2638041: code review 2638041: arm: prop up software floating point (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

arm: prop up software floating point Just enough to make mov instructions work, which in turn is enough to make strconv work when it avoids any floating point calculations. That makes a bunch of other packages pass their tests. Should suffice until hardware floating point is available. Enable package tests that now pass (some due to earlier fixes). Looks like there is a new integer math bug exposed in the fmt and json tests.

Patch Set 1 #

Patch Set 2 : code review 2638041: arm: prop up software floating point #

Patch Set 3 : code review 2638041: arm: prop up software floating point #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -32 lines)			Patch
M	src/cmd/5g/Makefile	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/5g/cgen.c	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	src/cmd/5g/gsubr.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/data.c	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/Makefile	View	1 2	1 chunk	+8 lines, -16 lines	0 comments	Download
M	src/pkg/runtime/arm/softfloat.c	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/pkg/strconv/atof.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/strconv/ftoa.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/pkg/strconv/internal_test.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-10-21 04:56:51 UTC) #1

rsc

14 years, 5 months ago (2010-10-21 04:57:04 UTC) #2

*** Submitted as 1f314c2262da ***

arm: prop up software floating point

Just enough to make mov instructions work,
which in turn is enough to make strconv work
when it avoids any floating point calculations.
That makes a bunch of other packages pass
their tests.

Should suffice until hardware floating point
is available.

Enable package tests that now pass
(some due to earlier fixes).

Looks like there is a new integer math bug
exposed in the fmt and json tests.

R=ken2
CC=golang-dev
http://codereview.appspot.com/2638041

Expand All Messages | Collapse All Messages