Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(796)

Issue 2627043: code review 2627043: go spec: append built-in (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by gri
Modified:
6 years, 9 months ago
Reviewers:
CC:
iant, ken2, r, rsc, golang-dev
Visibility:
Public.

Description

go spec: append built-in

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 2627043: go spec: append built-in #

Total comments: 5

Patch Set 3 : code review 2627043: go spec: append built-in #

Patch Set 4 : code review 2627043: go spec: append built-in #

Patch Set 5 : code review 2627043: go spec: append built-in #

Total comments: 1

Patch Set 6 : code review 2627043: go spec: append built-in #

Patch Set 7 : code review 2627043: go spec: append built-in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 2 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 13
gri
Hello iant, ken2, r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
6 years, 9 months ago (2010-10-22 21:16:07 UTC) #1
r
http://codereview.appspot.com/2627043/diff/1/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2627043/diff/1/doc/go_spec.html#newcode4540 doc/go_spec.html:4540: value must be of the form <code>v...</code> and the ...
6 years, 9 months ago (2010-10-22 22:07:17 UTC) #2
gri
PTAL Slightly reformulated. One could just let the append() signature speak for itself, but we ...
6 years, 9 months ago (2010-10-22 22:33:07 UTC) #3
rsc
there is no straightforward Go implementation of copy, because copy handles overlap. (there's a non-straightforward ...
6 years, 9 months ago (2010-10-22 23:01:25 UTC) #4
gri
PTAL On Fri, Oct 22, 2010 at 4:01 PM, Russ Cox <rsc@golang.org> wrote: > there ...
6 years, 9 months ago (2010-10-22 23:10:46 UTC) #5
r
6 years, 9 months ago (2010-10-22 23:36:58 UTC) #6
r
LGTM
6 years, 9 months ago (2010-10-22 23:37:06 UTC) #7
rsc1
http://codereview.appspot.com/2627043/diff/5001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2627043/diff/5001/doc/go_spec.html#newcode4541 doc/go_spec.html:4541: the type of <code>v</code> must be identical to <code>[]T</code>. ...
6 years, 9 months ago (2010-10-22 23:37:36 UTC) #8
gri
PTAL. On Fri, Oct 22, 2010 at 4:37 PM, <rsc@google.com> wrote: > > http://codereview.appspot.com/2627043/diff/5001/doc/go_spec.html > ...
6 years, 9 months ago (2010-10-23 05:01:12 UTC) #9
rsc1
http://codereview.appspot.com/2627043/diff/21001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2627043/diff/21001/doc/go_spec.html#newcode4558 doc/go_spec.html:4558: s4 := append(nil, s1...) // make a copy of ...
6 years, 9 months ago (2010-10-25 23:39:53 UTC) #10
gri
oops - version skew (changed at home but then overrode again at work) - PTAL. ...
6 years, 9 months ago (2010-10-25 23:46:33 UTC) #11
rsc1
LGTM
6 years, 9 months ago (2010-10-25 23:49:38 UTC) #12
gri
6 years, 9 months ago (2010-10-25 23:50:37 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=cde2eed1ded9 ***

go spec: append built-in

R=iant, ken2, r, rsc
CC=golang-dev
http://codereview.appspot.com/2627043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted