Issue 262630043: Bug 1210364 - Potential NULL deref after OOM in nssCertificateCollection_Create()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 262630043: Bug 1210364 - Potential NULL deref after OOM in nssCertificateCollection_Create() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 7 months ago by ttaubert

Modified:
8 years, 7 months ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1210364 - Potential NULL deref after OOM in nssCertificateCollection_Create()

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	lib/pki/pkibase.c	View		2 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

ekr-rietveld

8 years, 7 months ago (2015-10-01 15:13:11 UTC) #1

LGTM with comment.

https://codereview.appspot.com/262630043/diff/1/lib/pki/pkibase.c
File lib/pki/pkibase.c (right):

https://codereview.appspot.com/262630043/diff/1/lib/pki/pkibase.c#newcode1062
lib/pki/pkibase.c:1062: return (nssPKIObjectCollection *)NULL;
You don't need to cast NULL here or below.

Expand All Messages | Collapse All Messages