Issue 262560043: Remove/replace Simple_closure smob type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 262560043: Remove/replace Simple_closure smob type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 7 months ago by dak

Modified:
8 years, 1 month ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove/replace Simple_closure smob type Consists of commits (including patch from issue 4618): Rewrite call_pure_function Remove node "simple closure" from notation appendices Remove/replace Simple_closure smob type Import grob::compose-function and grob::offset-function into C Add grob::compose-function and grob::offset-function Those are the main replacements for the uses of ly:make-simple-closure in lily/grob-closure.cc. Add ly:pure-call and ly:unpure-call functions Remove unused function chain-grob-member-functions Issue 4618: Correct argument handling of Unpure_pure_call::call

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -271 lines)			Patch
M	Documentation/notation/notation-appendices.itely	View	4 chunks	+0 lines, -15 lines	0 comments	Download
M	lily/context-property.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	lily/grob-closure.cc	View	3 chunks	+4 lines, -39 lines	0 comments	Download
M	lily/grob-property.cc	View	8 chunks	+21 lines, -38 lines	0 comments	Download
M	lily/grob-scheme.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	lily/include/lily-imports.hh	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	lily/include/simple-closure.hh	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	lily/lily-imports.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lily/parenthesis-engraver.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	lily/simple-closure.cc	View	1 chunk	+0 lines, -123 lines	0 comments	Download
M	lily/unpure-pure-container.cc	View	2 chunks	+46 lines, -6 lines	0 comments	Download
M	scm/lily.scm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	scm/output-lib.scm	View	1 chunk	+47 lines, -8 lines	0 comments	Download