Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9536)

Issue 262500043: Correct argument handling of Unpure_pure_call::call (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by dak
Modified:
8 years, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Correct argument handling of Unpure_pure_call::call When ly:make-unpure-pure-container is called with a single procedure argument, this procedure is used for both unpure and pure calls. It turns out that the calling convention in call_pure_function places the start/end arguments always in position 2/3 of the call. Unpure_pure_call::call previously always dropped the last 2 arguments of a pure call before passing the rest on. Most calls take exactly 3 arguments (grob start end) where this does not make a difference, but there may be use cases with a different number of arguments.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M lily/unpure-pure-container.cc View 1 chunk +9 lines, -6 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b