Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(349)

Issue 262470043: Don't center letter fret labels but align them at their baseline (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by dak
Modified:
8 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't center letter fret labels but align them at their baseline Not sure this change of behavior is really wanted or the chosen value will be useful/appropriate. This particular change is in scm/translation-functions.scm. The issue contains another commit that is independently useful as it stops the redundantly hardwired behavior established in tab-note-head::print : Make TabNoteHead.X-offset operative It has been effectively overridden in tab-note-head::print which masked the missing default of self-alignment-X.

Patch Set 1 #

Patch Set 2 : Just bother with vertical alignment, horizontal is too messed up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M scm/tablature.scm View 1 3 chunks +6 lines, -7 lines 0 comments Download
M scm/translation-functions.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
dak
8 years, 5 months ago (2015-10-27 23:39:28 UTC) #1
Just bother with vertical alignment, horizontal is too messed up
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b