Issue 262380043: Fix svg backend explanation
DescriptionFix svg backend explanation
This commit fixes svg backend explanation.
Patch Set 1 #
Total comments: 8
Patch Set 2 : Fix sentence etc. #
Total comments: 6
Patch Set 3 : James' suggestions #MessagesTotal messages: 7
Hosada-san, See my comments below. https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... File Documentation/usage/running.itely (right): https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:478: SVG viewer environment should be installed the fonts which are used "SVG viewer environment should be installed the fonts which are .." This whole sentence doesn't make sense (grammatically or technically), could you explain what it is you are trying to say and perhaps we can come up with a better/simpler explanation for the users? https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:491: @strong{Note for svg backend:} The way this page looks in the PDFs is strange, I think you need to include this whole new text *before* the; --snip-- @item @tab @code{scm} ... --snip-- section. https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:494: Therefore, when using the svg backend, it is recommended that Recommended or required? https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:505: (/ staff-height pt 20))) What happens if you leave out this "/ staff-height" line? it seems rather an arbitrary value - or if I have my output for my score using smaller/larger fonts sizes will it cause any conflict?
Sign in to reply to this message.
Fix sentence etc.
Sign in to reply to this message.
Thank you for your comments. I've fixed some sentences. https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... File Documentation/usage/running.itely (right): https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:478: SVG viewer environment should be installed the fonts which are used On 2015/09/15 10:53:27, pkx166h wrote: > "SVG viewer environment should be installed the fonts which are .." > > This whole sentence doesn't make sense (grammatically or technically), could you > explain what it is you are trying to say and perhaps we can come up with a > better/simpler explanation for the users? I've tried to fix the sentence. How about this? https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:491: @strong{Note for svg backend:} On 2015/09/15 10:53:27, pkx166h wrote: > The way this page looks in the PDFs is strange, I think you need to include this > whole new text *before* the; > > --snip-- > > @item > @tab @code{scm} > ... > --snip-- > > section. I've changed the order of "scm" and "svg". https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:494: Therefore, when using the svg backend, it is recommended that On 2015/09/15 10:53:27, pkx166h wrote: > Recommended or required? Done. https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.i... Documentation/usage/running.itely:505: (/ staff-height pt 20))) On 2015/09/15 10:53:27, pkx166h wrote: > What happens if you leave out this "/ staff-height" line? it seems rather an > arbitrary value - or if I have my output for my score using smaller/larger fonts > sizes will it cause any conflict? Fourth argument is the font size factor. This calculation is the same as the default setting. Conflict will not occur.
Sign in to reply to this message.
Hosada-san, See my suggestions below. (I hope they are correct). https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... File Documentation/usage/running.itely (right): https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... Documentation/usage/running.itely:488: @end multitable I suggest this: " This creates a single SVG file for every page of output. Font information is not embedded so the SVG viewer will require the fonts be available for optimal rendering. It is recommended that you do not use @q{font aliases} or @q{font lists} in case your SVG viewer is not able to handle them. Also see the @code{svg-woff} option. https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... Documentation/usage/running.itely:496: See @ruser{Entire document fonts}. I suggest we say this: "LilyPond's default fonts (@code{LilyPond Serif}, @code{LilyPond Sans Serif} and @code{LilyPond Monospace}) are just @emph{local} font aliases; so when using the @code{svg} backend command it is required that you explicitly set the default fonts; https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... Documentation/usage/running.itely:509: The put here: @noindent Also see @ruser{Entire document fonts}.
Sign in to reply to this message.
James' suggestions
Sign in to reply to this message.
Thank you for your suggestions. https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... File Documentation/usage/running.itely (right): https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... Documentation/usage/running.itely:488: @end multitable On 2015/09/15 17:39:48, pkx166h wrote: > I suggest this: > > " This creates a single SVG file for every page of output. Font information is > not embedded so the SVG viewer will require the fonts be available for optimal > rendering. It is recommended that you do not use @q{font aliases} or @q{font > lists} in case your SVG viewer is not able to handle them. Also see the > @code{svg-woff} option. Done. https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... Documentation/usage/running.itely:496: See @ruser{Entire document fonts}. On 2015/09/15 17:39:48, pkx166h wrote: > I suggest we say this: > > "LilyPond's default fonts (@code{LilyPond Serif}, @code{LilyPond Sans Serif} and > @code{LilyPond Monospace}) are just @emph{local} font aliases; so when using the > @code{svg} backend command it is required that you explicitly set the default > fonts; Done. https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/runni... Documentation/usage/running.itely:509: On 2015/09/15 17:39:48, pkx166h wrote: > The put here: > > @noindent > Also see @ruser{Entire document fonts}. Done.
Sign in to reply to this message.
I've pushed to staging. Issue 4605: Doc: Usage - Fix svg backend explanation author Masamichi Hosoda <trueroad@trueroad.jp> Mon, 14 Sep 2015 14:40:51 +0000 (23:40 +0900) committer Masamichi Hosoda <trueroad@trueroad.jp> Wed, 23 Sep 2015 07:32:59 +0000 (16:32 +0900) commit 6ea18ce2f407ee754947a4fa18596bb38c8087f5
Sign in to reply to this message.
|
