Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 262330043: Issue 4591: Fix font-name overriding

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by trueroad
Modified:
9 years, 12 months ago
Reviewers:
pkx, dak, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4591: Fix font-name overriding Issue 4591 / 5: NR: Add font-name description This commit addsing font-name description. Issue 4591 / 4: NR: Enhance font-name overriding sample font-name can be described a comma separated list of font families and a whitespace separated list of font styles (shape, series etc.). Issue 4591 / 3: Fix font-name overriding wrong name Some font family do not exist. This commit replaces them with correct font family names. Issue 4591 / 2: Fix font-name overriding deprecated name Generic font family alias `Sans' is deprecated. This commit replaces it with `LilyPond Sans Serif' that is a font family alias of LilyPond's default sans serif font. Issue 4591 / 1: Fix font-name overriding `Times New Roman' A comma is required for font family name "Times New Roman"'s explicit termination. If there is no comma, Pango interpret "Times New Roman" as "Times New" family with "Roman" style.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change English wording #

Total comments: 3

Patch Set 3 : Clean up #

Patch Set 4 : Change some term #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M Documentation/de/notation/text.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/text.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/text.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/it/notation/text.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/text.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/notation/text.itely View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
A + Documentation/snippets/new/changing-stanza-fonts.ly View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M Documentation/snippets/new/unfretted-headword.ly View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/font-name.ly View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download
M input/regression/markup-music-glyph.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/metronome-mark-formatter.ly View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12
pkx
Suggested change to the English wording. https://codereview.appspot.com/262330043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/262330043/diff/1/Documentation/notation/text.itely#newcode1547 Documentation/notation/text.itely:1547: If first font ...
10 years ago (2015-09-07 14:34:48 UTC) #1
trueroad
Change English wording
10 years ago (2015-09-07 15:12:27 UTC) #2
trueroad
I've updated the patch. https://codereview.appspot.com/262330043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/262330043/diff/1/Documentation/notation/text.itely#newcode1547 Documentation/notation/text.itely:1547: If first font family in ...
10 years ago (2015-09-07 15:16:29 UTC) #3
thomasmorley651
Some nitpick, see below. Otherwise LGTM https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly File Documentation/snippets/new/unfretted-headword.ly (right): https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly#newcode119 Documentation/snippets/new/unfretted-headword.ly:119: \set Score.markFormatter = ...
10 years ago (2015-09-07 21:11:49 UTC) #4
dak
https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly File Documentation/snippets/new/unfretted-headword.ly (right): https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly#newcode119 Documentation/snippets/new/unfretted-headword.ly:119: \set Score.markFormatter = #format-mark-box-numbers On 2015/09/07 21:11:48, thomasmorley651 wrote: ...
10 years ago (2015-09-07 21:31:46 UTC) #5
thomasmorley651
https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly File Documentation/snippets/new/unfretted-headword.ly (right): https://codereview.appspot.com/262330043/diff/20001/Documentation/snippets/new/unfretted-headword.ly#newcode119 Documentation/snippets/new/unfretted-headword.ly:119: \set Score.markFormatter = #format-mark-box-numbers On 2015/09/07 21:31:45, dak wrote: ...
10 years ago (2015-09-07 21:39:16 UTC) #6
trueroad
Clean up
10 years ago (2015-09-08 13:05:56 UTC) #7
trueroad
I've added cleaning up etc. Issue 4591 / 6: Clean up Alignment spacing only.
10 years ago (2015-09-08 13:08:07 UTC) #8
trueroad
Change some term
10 years ago (2015-09-10 11:16:54 UTC) #9
trueroad
I've noticed that LilyPond' font-family and Pango/Fontconfig's font family are quite a different thing. To ...
10 years ago (2015-09-10 12:18:26 UTC) #10
trueroad
Issue 4591 / 6: Clean up Alignment spacing only. Issue 4591 / 5: NR: Add ...
10 years ago (2015-09-10 13:21:41 UTC) #11
trueroad
9 years, 12 months ago (2015-09-17 14:41:12 UTC) #12
I've uploaded to staging.

Issue 4591 / 1: Fix font-name overriding `Times New Roman'
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 7 Sep 2015 11:04:50 +0000 (20:04 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Thu, 17 Sep 2015 14:28:14 +0000 (23:28 +0900)
commit    64d2c3f619587207c1dcd22f573b9ff4ff34d04f

Issue 4591 / 2: Fix font-name overriding deprecated name
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 7 Sep 2015 11:59:19 +0000 (20:59 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Thu, 17 Sep 2015 14:28:14 +0000 (23:28 +0900)
commit    1e8a9855c7b9455b6bb95c6894b79eead3f5f7b3

Issue 4591 / 3: Fix font-name overriding wrong name
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 7 Sep 2015 13:12:56 +0000 (22:12 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Thu, 17 Sep 2015 14:28:15 +0000 (23:28 +0900)
commit    d0980c892d79010a9506aa5b7da504181ba5b632

Issue 4591 / 4: NR: Enhance font-name overriding sample
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 7 Sep 2015 13:30:23 +0000 (22:30 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Thu, 17 Sep 2015 14:28:15 +0000 (23:28 +0900)
commit    15c207fe1e0c7a70184ec82e9f060d3ae599326d

Issue 4591 / 5: NR: Add font-name description
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Mon, 7 Sep 2015 13:49:14 +0000 (22:49 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Thu, 17 Sep 2015 14:28:16 +0000 (23:28 +0900)
commit    c6035c9f68d892a37855edf6acb5e9d0fbec7267

Issue 4591 / 6: Clean up
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Tue, 8 Sep 2015 12:57:06 +0000 (21:57 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Thu, 17 Sep 2015 14:28:16 +0000 (23:28 +0900)
commit    2a4c5137870acf1b1fd2f3307d98973a52cfc8b9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b