Common container: 2 small rpc updates

- allow container client to register rpc and work with calling GadgetSite.
- removed unused (by Shindig) onload rpc service.

[mhermanto, 2010-10-20 23:40:57]

Update patch

[johnfargo, 2010-10-22 20:15:35]

http://codereview.appspot.com/2623041/diff/14001/features/src/main/javascript...
File features/src/main/javascript/features/container/container.js (right):

http://codereview.appspot.com/2623041/diff/14001/features/src/main/javascript...
features/src/main/javascript/features/container/container.js:257: callback(site,
data);
to be more generic (and less "magical") we could instead just bind "this" of
"callback" to "self", while applying the inbound arguments rather than fixing
their number at 1:

var argsCopy = [];
for (var i = 0; i < arguments.length; ++i) {
  argsCopy.push(arguments[i]);
}
callback.apply(self, argsCopy);

[mhermanto, 2010-10-26 03:21:13]

Update patch

[mhermanto, 2010-10-26 03:23:43]

On 2010/10/22 20:15:35, johnfargo wrote:
>
http://codereview.appspot.com/2623041/diff/14001/features/src/main/javascript...
> File features/src/main/javascript/features/container/container.js (right):
> 
>
http://codereview.appspot.com/2623041/diff/14001/features/src/main/javascript...
> features/src/main/javascript/features/container/container.js:257:
callback(site,
> data);
> to be more generic (and less "magical") we could instead just bind "this" of
> "callback" to "self", while applying the inbound arguments rather than fixing
> their number at 1:
> 
> var argsCopy = [];
> for (var i = 0; i < arguments.length; ++i) {
>   argsCopy.push(arguments[i]);
> }
> callback.apply(self, argsCopy);

Good comment. I initially implement with the GadgetSite context to abstract away
the calling gadget (or site in CC). I've augment this gadget site as part of the
rpc args, in a bag-style fashion. PTAL.

[johnfargo, 2010-10-26 19:11:46]

http://codereview.appspot.com/2623041/diff/18001/features/src/main/javascript...
File features/src/main/javascript/features/container/container.js (right):

http://codereview.appspot.com/2623041/diff/18001/features/src/main/javascript...
features/src/main/javascript/features/container/container.js:259: var argsCopy =
[ this ];
given that you're copying over the "from" bit, you can probably get rid of this
first argument. You may also want to copy over the rpc callback ("callback")
field.

[mhermanto, 2010-10-26 22:02:54]

Talked offline. Left as is.

On Tue, Oct 26, 2010 at 12:11 PM, <johnfargo@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/2623041/diff/18001/features/src/main/javascript...
>
> File features/src/main/javascript/features/container/container.js
> (right):
>
>
>
http://codereview.appspot.com/2623041/diff/18001/features/src/main/javascript...
> features/src/main/javascript/features/container/container.js:259: var
> argsCopy = [ this ];
> given that you're copying over the "from" bit, you can probably get rid
> of this first argument. You may also want to copy over the rpc callback
> ("callback") field.
>
>
> http://codereview.appspot.com/2623041/
>

[johnfargo, 2010-10-26 22:06:42]

LGTM

Thanks for the patience.

On Tue, Oct 26, 2010 at 3:02 PM, Michael Hermanto <mhermanto@gmail.com>wrote:

> Talked offline. Left as is.
>
>
> On Tue, Oct 26, 2010 at 12:11 PM, <johnfargo@gmail.com> wrote:
>
>>
>>
>>
http://codereview.appspot.com/2623041/diff/18001/features/src/main/javascript...
>>
>> File features/src/main/javascript/features/container/container.js
>> (right):
>>
>>
>>
http://codereview.appspot.com/2623041/diff/18001/features/src/main/javascript...
>> features/src/main/javascript/features/container/container.js:259: var
>> argsCopy = [ this ];
>> given that you're copying over the "from" bit, you can probably get rid
>> of this first argument. You may also want to copy over the rpc callback
>> ("callback") field.
>>
>>
>> http://codereview.appspot.com/2623041/
>>
>
>