Issue 262000043: GSoC 2015 - FinalTerm Milestone - Carrier Aggregation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 262000043: GSoC 2015 - FinalTerm Milestone - Carrier Aggregation

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by dabrignani

Modified:
9 years, 8 months ago

Reviewers:
Nicola Baldo, Marco Miozzo

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

This is code review request for GSoC 2015, LTE CA Support. For more information see https://www.nsnam.org/wiki/GSOC2015LTECA

Patch Set 1 #

Created: 9 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+14878 lines, -8587 lines)			Patch
M	src/core/model/make-event.h	View	15 chunks	+241 lines, -108 lines	0 comments	Download
M	src/core/model/simulator.h	View	30 chunks	+596 lines, -802 lines	0 comments	Download
A	src/lte/doc/source/CarrierAggregationDownlinkDataPlane.seqdiag	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	src/lte/doc/source/CarrierAggregationUlTxOpportunity.seqdiag	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	src/lte/doc/source/figures/ca-rrc-messages.png	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/carrier-aggregation-impact.png	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/carrier-aggregation-mac-impact.png	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/convert_workaround.sh	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	src/lte/doc/source/figures/lte-a-arch-enb-ctrl-rrc-phy	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-enb-ctrl-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-enb-ctrl-rrc-phy.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-enb-data-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-enb-data-carrier-aggregation.dia.autosave	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-ue-ctrl-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-ue-data-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-ca-enable-procedure.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-ccs-arch.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-ccs-arch.png	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-class-net-phy-relation.dia	View	Binary file		0 comments	Download
M	src/lte/doc/source/lte-design.rst	View	1 chunk	+118 lines, -0 lines	0 comments	Download
A	src/lte/doc/source/setupRadioBearerCarrierAggregation.seqdiag	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	src/lte/helper/cc-helper.h	View	1 chunk	+137 lines, -0 lines	0 comments	Download
A	src/lte/helper/cc-helper.cc	View	1 chunk	+166 lines, -0 lines	0 comments	Download
M	src/lte/helper/lte-helper.h	View	22 chunks	+135 lines, -41 lines	0 comments	Download
M	src/lte/helper/lte-helper.cc	View	32 chunks	+520 lines, -234 lines	0 comments	Download
M	src/lte/helper/mac-stats-calculator.cc	View	4 chunks	+14 lines, -7 lines	0 comments	Download
M	src/lte/helper/phy-rx-stats-calculator.cc	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/lte/helper/phy-stats-calculator.cc	View	6 chunks	+14 lines, -9 lines	0 comments	Download
M	src/lte/helper/phy-tx-stats-calculator.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/lte/helper/radio-bearer-stats-calculator.cc	View	1 chunk	+554 lines, -554 lines	0 comments	Download
A	src/lte/model/component-carrier.h	View	1 chunk	+163 lines, -0 lines	0 comments	Download
A	src/lte/model/component-carrier.cc	View	1 chunk	+241 lines, -0 lines	0 comments	Download
A	src/lte/model/component-carrier-enb.h	View	1 chunk	+92 lines, -0 lines	0 comments	Download
A	src/lte/model/component-carrier-enb.cc	View	1 chunk	+165 lines, -0 lines	0 comments	Download
A	src/lte/model/component-carrier-ue.h	View	1 chunk	+73 lines, -0 lines	0 comments	Download
A	src/lte/model/component-carrier-ue.cc	View	1 chunk	+109 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-asn1-header.h	View	4 chunks	+21 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-asn1-header.cc	View	4 chunks	+12 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ccm-rrc-sap.h	View	1 chunk	+225 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ccm-rrc-sap.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-component-carrier-manager.h	View	1 chunk	+116 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-component-carrier-manager.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-enb-component-carrier-manager.h	View	1 chunk	+183 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-enb-component-carrier-manager.cc	View	1 chunk	+107 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-enb-mac.h	View	10 chunks	+32 lines, -11 lines	0 comments	Download
M	src/lte/model/lte-enb-mac.cc	View	10 chunks	+39 lines, -5 lines	0 comments	Download
M	src/lte/model/lte-enb-net-device.h	View	7 chunks	+36 lines, -6 lines	0 comments	Download
M	src/lte/model/lte-enb-net-device.cc	View	11 chunks	+78 lines, -16 lines	0 comments	Download
M	src/lte/model/lte-enb-phy.h	View	3 chunks	+6 lines, -8 lines	0 comments	Download
M	src/lte/model/lte-enb-phy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lte/model/lte-enb-rrc.h	View	23 chunks	+73 lines, -28 lines	0 comments	Download
M	src/lte/model/lte-enb-rrc.cc	View	39 chunks	+258 lines, -67 lines	0 comments	Download
M	src/lte/model/lte-mac-sap.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/lte/model/lte-rlc.h	View	4 chunks	+9 lines, -6 lines	0 comments	Download
M	src/lte/model/lte-rlc.cc	View	6 chunks	+40 lines, -7 lines	0 comments	Download
M	src/lte/model/lte-rlc-am.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-rlc-am.cc	View	3 chunks	+541 lines, -3 lines	0 comments	Download
M	src/lte/model/lte-rlc-tm.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-rlc-tm.cc	View	3 chunks	+53 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-rlc-um.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-rlc-um.cc	View	3 chunks	+273 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-rrc-header.h	View	5 chunks	+24 lines, -1 line	0 comments	Download
M	src/lte/model/lte-rrc-header.cc	View	3 chunks	+7011 lines, -6391 lines	0 comments	Download
M	src/lte/model/lte-rrc-protocol-real.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/lte/model/lte-rrc-sap.h	View	3 chunks	+114 lines, -2 lines	0 comments	Download
M	src/lte/model/lte-rrc-sap.cc	View	1 chunk	+22 lines, -22 lines	0 comments	Download
A	src/lte/model/lte-ue-ccm-rrc-sap.h	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ue-ccm-rrc-sap.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ue-component-carrier-manager.h	View	1 chunk	+105 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ue-component-carrier-manager.cc	View	1 chunk	+90 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-ue-mac.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-ue-mac.cc	View	8 chunks	+17 lines, -6 lines	0 comments	Download
M	src/lte/model/lte-ue-net-device.h	View	8 chunks	+16 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-ue-net-device.cc	View	9 chunks	+56 lines, -10 lines	0 comments	Download
M	src/lte/model/lte-ue-phy.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-ue-rrc.h	View	16 chunks	+61 lines, -11 lines	0 comments	Download
M	src/lte/model/lte-ue-rrc.cc	View	79 chunks	+296 lines, -198 lines	0 comments	Download
A	src/lte/model/lte-ul-ccm-mac-sap.h	View	1 chunk	+114 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ul-ccm-mac-sap.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	src/lte/model/no-op-component-carrier-manager.h	View	1 chunk	+121 lines, -0 lines	0 comments	Download
A	src/lte/model/no-op-component-carrier-manager.cc	View	1 chunk	+479 lines, -0 lines	0 comments	Download
A	src/lte/model/simple-ue-component-carrier-manager.h	View	1 chunk	+108 lines, -0 lines	0 comments	Download
A	src/lte/model/simple-ue-component-carrier-manager.cc	View	1 chunk	+331 lines, -0 lines	0 comments	Download
M	src/lte/test/lte-test-entities.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/lte/test/lte-test-ue-measurements.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/lte/test/test-asn1-encoding.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/lte/test/test-lte-antenna.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/lte/wscript	View	2 chunks	+23 lines, -1 line	0 comments	Download