code review 2616041: encoding/hex: fix typo

encoding/hex: fix typo

Thanks to avadh4all for spotting it.

Fixes issue 1214.

[rsc, 2010-10-20 20:33:17]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-10-20 20:36:45]

LGTM

On Oct 20, 2010, at 1:33 PM, rsc@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> encoding/hex: fix typo
> 
> Thanks to avadh4all for spotting it.
> 
> Fixes issue 1214.
> 
> Please review this at http://codereview.appspot.com/2616041/
> 
> Affected files:
>  M src/pkg/encoding/hex/hex.go
>  M src/pkg/encoding/hex/hex_test.go
> 
> 
> Index: src/pkg/encoding/hex/hex.go
> ===================================================================
> --- a/src/pkg/encoding/hex/hex.go
> +++ b/src/pkg/encoding/hex/hex.go
> @@ -71,7 +71,7 @@
> // fromHexChar converts a hex character into its value and a success flag.
> func fromHexChar(c byte) (byte, bool) {
> 	switch {
> -	case 0 <= c && c <= '9':
> +	case '0' <= c && c <= '9':
> 		return c - '0', true
> 	case 'a' <= c && c <= 'f':
> 		return c - 'a' + 10, true
> Index: src/pkg/encoding/hex/hex_test.go
> ===================================================================
> --- a/src/pkg/encoding/hex/hex_test.go
> +++ b/src/pkg/encoding/hex/hex_test.go
> @@ -58,6 +58,7 @@
> 	decodeTest{[]byte{}, []byte{}, true},
> 	decodeTest{[]byte{'0'}, []byte{}, false},
> 	decodeTest{[]byte{'0', 'g'}, []byte{}, false},
> +	decodeTest{[]byte{'0', '\x01'}, []byte{}, false},
> 	decodeTest{[]byte{'0', '0'}, []byte{0}, true},
> 	decodeTest{[]byte{'0', '1'}, []byte{1}, true},
> 	decodeTest{[]byte{'0', '2'}, []byte{2}, true},
> @@ -129,6 +130,7 @@
> 	decodeStringTest{"", []byte{}, true},
> 	decodeStringTest{"0", []byte{}, false},
> 	decodeStringTest{"00", []byte{0}, true},
> +	decodeStringTest{"0\x01", []byte{}, false},
> 	decodeStringTest{"0g", []byte{}, false},
> 	decodeStringTest{"00ff00", []byte{0, 255, 0}, true},
> 	decodeStringTest{"0000ff", []byte{0, 0, 255}, true},
> 
> 

[rsc, 2010-10-20 20:38:59]

*** Submitted as f6cb47a6e4fd ***

encoding/hex: fix typo

Thanks to avadh4all for spotting it.

Fixes issue 1214.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/2616041