Issue 2609041: code review 2609041: 6l: correct logic for morestack choice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2609041: code review 2609041: 6l: correct logic for morestack choice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

6l: correct logic for morestack choice The frame that gets allocated is for both the args and the autos. If together they exceed the default frame size, we need to tell morestack about both so that it allocates a large enough frame. Sanity check stack pointer in morestack to catch similar bugs.