ticket:11783: Remove use of class loaders in resource loading caches.

ticket:11783: Remove use of class loaders in resource loading caches.

There is currently no known use-case where this code that is being
removed solves a real problem, but it causes problems in Android when
ICU4J is being initialized using one class loader but then called using
another class loader.

R=markus.icu@gmail.com, yoshito_umaoka@us.ibm.com

Committed: http://bugs.icu-project.org/trac/changeset/37920

[markus.icu, 2015-09-08 22:02:13]

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/ICUResourceBundleReader.java
(right):

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/ICUResourceBundleReader.java:177: private
static class ReaderCache extends SoftCache<ReaderInfo, ICUResourceBundleReader,
ReaderInfo> {
This existing code is confusing. Please try to
- change this to extends SoftCache<ReaderInfo, ICUResourceBundleReader,
ClassLoader>
- change createInstance second arg to "ClassLoader loader"
- change createInstance "data.loader" to "loader"
- change createInstance other uses of "data." to "key."
- further down change  CACHE.getInstance(info, info)  to 
CACHE.getInstance(info, root)
- remove the loader field & constructor arg from ReaderInfo

Optional: rename ReaderInfo to ReaderCacheKey or similar

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/util/UResourceBundle.java (right):

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/util/UResourceBundle.java:532: ClassLoader
root, boolean disableFallback) {
please undo indent

[roubert (google), 2015-09-09 13:54:24]

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/ICUResourceBundleReader.java
(right):

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/ICUResourceBundleReader.java:177: private
static class ReaderCache extends SoftCache<ReaderInfo, ICUResourceBundleReader,
ReaderInfo> {
On 2015/09/08 22:02:12, markus.icu wrote:
> This existing code is confusing. Please try to
> - change this to extends SoftCache<ReaderInfo, ICUResourceBundleReader,
> ClassLoader>
> - change createInstance second arg to "ClassLoader loader"
> - change createInstance "data.loader" to "loader"
> - change createInstance other uses of "data." to "key."
> - further down change  CACHE.getInstance(info, info)  to 
> CACHE.getInstance(info, root)
> - remove the loader field & constructor arg from ReaderInfo
> 
> Optional: rename ReaderInfo to ReaderCacheKey or similar

Done.

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/util/UResourceBundle.java (right):

https://codereview.appspot.com/260600044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/util/UResourceBundle.java:532: ClassLoader
root, boolean disableFallback) {
On 2015/09/08 22:02:12, markus.icu wrote:
> please undo indent

Done.

[markus.icu, 2015-09-09 15:44:39]

LGTM

If Yoshito does not respond by your(!) EOD today then please submit to trunk.
The ticket is already marked for his (then post-submit) review.

[roubert (google), 2015-09-09 18:42:53]

Committed patchset #2 (id:20001) manually as 37920 (presubmit successful).