Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1197)

Issue 2592041: code review 2592041: build: add gobuilder and goplay to run.bash (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by adg
Modified:
14 years, 4 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

build: add gobuilder and goplay to run.bash gobuilder: fix build to work with new log package

Patch Set 1 #

Patch Set 2 : code review 2592041: builder: add to pkg/Makefile, fix build #

Patch Set 3 : code review 2592041: builder: add to pkg/Makefile, fix build #

Patch Set 4 : code review 2592041: build: add gobuilder and goplay to make.bash #

Total comments: 1

Patch Set 5 : code review 2592041: build: add gobuilder and goplay to run.bash #

Patch Set 6 : code review 2592041: build: add gobuilder and goplay to run.bash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M misc/dashboard/builder/main.go View 1 5 chunks +9 lines, -9 lines 0 comments Download
M src/run.bash View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 4 months ago (2010-10-19 23:43:23 UTC) #1
adg
On 20 October 2010 10:43, <adg@golang.org> wrote: > + ../../misc/dashboard/builder\ > + ../../misc/goplay\ I tried ...
14 years, 4 months ago (2010-10-19 23:51:32 UTC) #2
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-10-20 03:18:00 UTC) #3
rsc1
http://codereview.appspot.com/2592041/diff/5002/src/make.bash File src/make.bash (right): http://codereview.appspot.com/2592041/diff/5002/src/make.bash#newcode62 src/make.bash:62: for i in lib9 libbio libmach cmd pkg ../misc/dashboard/builder ...
14 years, 4 months ago (2010-10-20 03:21:02 UTC) #4
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-10-20 05:41:16 UTC) #5
rsc1
LGTM
14 years, 4 months ago (2010-10-20 14:43:07 UTC) #6
adg
14 years, 4 months ago (2010-10-20 23:46:15 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=f0ce3198240a ***

build: add gobuilder and goplay to run.bash
gobuilder: fix build to work with new log package

R=rsc
CC=golang-dev
http://codereview.appspot.com/2592041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b