Issue 258950043: Implement Slice.isTopLevel

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 258950043: Implement Slice.isTopLevel (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by benjhayden

Modified:
9 years, 10 months ago

Reviewers:
nduca, nduca(google)

CC:
tracing-review_chromium.org

Base URL:
git@github.com:google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Implement Slice.isTopLevel BUG= R=nduca@google.com Committed: https://chromium.googlesource.com/external/trace-viewer/+/9cfc45d826e1fad091158f5492e9961196d57691

Patch Set 2 : draw_helpers, test #

Total comments: 2

Patch Set 3 : async #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
M	tracing/tracing/model/slice.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tracing/tracing/model/slice_group.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tracing/tracing/model/slice_group_test.html	View	1	4 chunks	+8 lines, -0 lines	0 comments	Download
M	tracing/tracing/ui/base/draw_helpers.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

nduca(google)

did you test the ui to see if it'd changed? pretty sure you need to ...

9 years, 10 months ago (2015-07-24 18:14:02 UTC) #2

nduca(google)

lgtm https://codereview.appspot.com/258950043/diff/20001/tracing/tracing/ui/base/draw_helpers.html File tracing/tracing/ui/base/draw_helpers.html (right): https://codereview.appspot.com/258950043/diff/20001/tracing/tracing/ui/base/draw_helpers.html#newcode188 tracing/tracing/ui/base/draw_helpers.html:188: if (slice instanceof tr.model.AsyncSlice && lgtm but just ...

9 years, 10 months ago (2015-07-24 21:41:35 UTC) #4

benjhayden

https://codereview.appspot.com/258950043/diff/20001/tracing/tracing/ui/base/draw_helpers.html File tracing/tracing/ui/base/draw_helpers.html (right): https://codereview.appspot.com/258950043/diff/20001/tracing/tracing/ui/base/draw_helpers.html#newcode188 tracing/tracing/ui/base/draw_helpers.html:188: if (slice instanceof tr.model.AsyncSlice && On 2015/07/24 21:41:35, nduca(google) ...

9 years, 10 months ago (2015-07-24 22:45:51 UTC) #5

benjhayden

9 years, 10 months ago (2015-07-24 22:46:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
9cfc45d826e1fad091158f5492e9961196d57691 (presubmit successful).

Expand All Messages | Collapse All Messages