Issue 258920043: Table should not display undefined values.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 258920043: Table should not display undefined values. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by egon

Modified:
8 years, 9 months ago

Reviewers:
nduca, nduca(google)

CC:
tracing-review_chromium.org

Base URL:
https://github.com/google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Table should not display undefined values. R=nduca@google.com, nduca Committed: https://chromium.googlesource.com/external/trace-viewer/+/154d85a6f2f44b836cbda7b4b6001298981401b9

Patch Set 1 #

Total comments: 1

Patch Set 2 : skip inserting text instead of enforcing to empty string. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	tracing/tracing/ui/base/table.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tracing/tracing/ui/base/table_test.html	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nduca(google)

maybe a shift but lgtm when you settle on somethign that works https://codereview.appspot.com/258920043/diff/1/tracing/tracing/ui/base/table.html File tracing/tracing/ui/base/table.html ...

8 years, 9 months ago (2015-07-21 18:09:41 UTC) #2

egon

On 2015/07/21 18:09:41, nduca(google) wrote: > maybe a shift but lgtm when you settle on ...

8 years, 9 months ago (2015-07-21 18:22:24 UTC) #3

egon

8 years, 9 months ago (2015-07-22 05:30:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
154d85a6f2f44b836cbda7b4b6001298981401b9 (presubmit successful).

Expand All Messages | Collapse All Messages