Issue 258850043: Add TraceViewer.showOptions for hiding options.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 258850043: Add TraceViewer.showOptions for hiding options. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by egon

Modified:
9 years, 3 months ago

Reviewers:
nduca, nduca(google)

CC:
tracing-review_chromium.org, charliea

Base URL:
https://github.com/google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Add TraceViewer.showOptions for hiding options. BUG=#906 R=nduca@google.com

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	tracing/tracing/ui/timeline_view.html	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nduca

i'm not sure i really support hiding the options dropdown. i think we should look ...

9 years, 3 months ago (2015-07-21 14:21:34 UTC) #2

nduca

@charliea is working on moving vsync to the trace model [right now its in a ...

9 years, 3 months ago (2015-07-21 14:22:29 UTC) #3

egon

9 years, 3 months ago (2015-07-21 14:31:32 UTC) #4

On 2015/07/21 14:22:29, nduca wrote:
> @charliea is working on moving vsync to the trace model [right now its in a
> strange place] so when its there, seeing if the model has vsync will be just
as
> easy as adding model.device.hasVsyncEvents.

I'll drop this change then.

Expand All Messages | Collapse All Messages