Issue 257920043: Rewrite chrome_test_utils

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 257920043: Rewrite chrome_test_utils (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by benjhayden

Modified:
8 years, 9 months ago

Reviewers:
dsinclair

CC:
tracing-review_chromium.org

Base URL:
git@github.com:google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Rewrite chrome_test_utils Reland https://codereview.appspot.com/255850043/ Make RAILIRFinder log an error instead of throwing an exception when there are multiple FlingStart events. BUG=#1126 R=dsinclair@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/1b1423daa27888c4fc68bdf0803b4ae383c37048

Patch Set 1 #

Patch Set 2 : oops #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -87 lines)			Patch
M	tracing/tracing/extras/chrome/chrome_browser_helper.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tracing/tracing/extras/chrome/chrome_browser_helper_test.html	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	tracing/tracing/extras/chrome/chrome_test_utils.html	View	1	1 chunk	+8 lines, -38 lines	0 comments	Download
M	tracing/tracing/extras/rail/rail_ir_finder.html	View		3 chunks	+21 lines, -18 lines	0 comments	Download
M	tracing/tracing/extras/rail/rail_ir_finder_test.html	View		8 chunks	+26 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjhayden

8 years, 9 months ago (2015-07-23 23:49:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1b1423daa27888c4fc68bdf0803b4ae383c37048 (presubmit successful).

Expand All Messages | Collapse All Messages