Issue 257190043: Replace one newSliceNamed with newSliceEx

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 257190043: Replace one newSliceNamed with newSliceEx (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by benjhayden

Modified:
10 years, 8 months ago

Reviewers:
nduca, nduca(google)

CC:
tracing-review_chromium.org

Base URL:
git@github.com:google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Replace one newSliceNamed with newSliceEx BUG=#943 R=nduca@google.com Committed: https://chromium.googlesource.com/external/trace-viewer/+/8b8bcc7b1fdbc259351ca877eb93b92efaeede3f

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tracing/tracing/model/model_test.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjhayden

10 years, 8 months ago (2015-08-03 17:26:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b8bcc7b1fdbc259351ca877eb93b92efaeede3f (presubmit successful).

Expand All Messages | Collapse All Messages