src/pkg/runtime/malloc.cgo - Issue 257041: code review 257041: runtime: clock garbage collection on bytes allocated, n...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/malloc.cgo

Issue 257041: code review 257041: runtime: clock garbage collection on bytes allocated, n... (Closed)

Patch Set: code review 257041: runtime: clock garbage collection on bytes allocated, n... Created 15 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/malloc.cgo

===================================================================

--- a/src/pkg/runtime/malloc.cgo

+++ b/src/pkg/runtime/malloc.cgo

@@ -61,7 +61,7 @@

npages = size >> PageShift;

if((size & PageMask) != 0)

npages++;

- s = MHeap_Alloc(&mheap, npages, 0);

+ s = MHeap_Alloc(&mheap, npages, 0, 1);

if(s == nil)

throw("out of memory");

mstats.alloc += npages<<PageShift;

@@ -74,7 +74,7 @@

m->mallocing = 0;

- if(dogc && mstats.inuse_pages > mstats.next_gc)

+ if(dogc && mstats.heap_alloc >= mstats.next_gc)

gc(0);

return v;

}

@@ -113,7 +113,7 @@

// Large object.

mstats.alloc -= s->npages<<PageShift;

runtime_memclr(v, s->npages<<PageShift);

- MHeap_Free(&mheap, s);

+ MHeap_Free(&mheap, s, 1);

} else {

// Small object.

c = m->mcache;

« no previous file with comments | « src/pkg/runtime/malloc.h ('k') | src/pkg/runtime/mcache.c » ('j') | no next file with comments »