Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 25550043: Initial kvm interfaces and mock implementation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by thumper
Modified:
10 years, 5 months ago
Reviewers:
wallyworld, mp+194946
Visibility:
Public.

Description

Initial kvm interfaces and mock implementation. Lots of initial boilerplate. https://code.launchpad.net/~thumper/juju-core/kvm-containers/+merge/194946 Requires: https://code.launchpad.net/~thumper/juju-core/container-directory/+merge/194780 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+692 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A container/kvm/container.go View 1 chunk +36 lines, -0 lines 0 comments Download
A container/kvm/containerfactory.go View 1 chunk +24 lines, -0 lines 0 comments Download
A container/kvm/instance.go View 1 chunk +65 lines, -0 lines 0 comments Download
A container/kvm/interface.go View 1 chunk +37 lines, -0 lines 0 comments Download
A container/kvm/kvm.go View 1 chunk +92 lines, -0 lines 1 comment Download
A container/kvm/kvm_test.go View 1 chunk +62 lines, -0 lines 0 comments Download
A container/kvm/mock/mock-kvm.go View 1 chunk +149 lines, -0 lines 0 comments Download
A container/kvm/mock/mock-kvm_test.go View 1 chunk +161 lines, -0 lines 0 comments Download
A container/kvm/mock/package_test.go View 1 chunk +14 lines, -0 lines 0 comments Download
A container/kvm/package_test.go View 1 chunk +14 lines, -0 lines 0 comments Download
A container/kvm/testing/test.go View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2
thumper
Please take a look.
10 years, 5 months ago (2013-11-12 21:31:18 UTC) #1
wallyworld
10 years, 5 months ago (2013-11-12 22:56:31 UTC) #2
LGTM with the IsKVMSupported method returning bool,error

Part of me wonders if, as the implementation is fleshed out, whether it will
become worth adding a gokvm package to match the golxc package. Time will tell I
guess.

https://codereview.appspot.com/25550043/diff/1/container/kvm/kvm.go
File container/kvm/kvm.go (right):

https://codereview.appspot.com/25550043/diff/1/container/kvm/kvm.go#newcode26
container/kvm/kvm.go:26: var IsKVMSupported = func() bool {
As discussed, make this return (bool, error)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b