Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1190)

Issue 255043: code review 255043: gc: fix crash on complicated arg to make slice. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by rsc
Modified:
14 years, 2 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: fix crash on complicated arg to make slice. Fixes issue 615.

Patch Set 1 #

Patch Set 2 : code review 255043: gc: fix crash on complicated arg to make slice. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/walk.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2010-03-06 03:29:12 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=02873ea57081 *** gc: fix crash on complicated arg to make slice. Fixes ...
14 years, 2 months ago (2010-03-06 03:29:16 UTC) #2
ken3
14 years, 2 months ago (2010-03-06 04:26:18 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b