Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1626)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 254360043: Move all d8 code to vinn. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by nednguyen
Modified:
8 years, 9 months ago
Reviewers:
nduca, nduca(google)
CC:
tracing-review_chromium.org
Base URL:
https://github.com/google/trace-viewer.git@master
Visibility:
Public.

Description

Move all d8 code to vinn. BUG=https://github.com/google/trace-viewer/issues/1121 R=nduca@google.com Committed: https://chromium.googlesource.com/external/trace-viewer/+/10842fecce208811028980d626bec9bd7e77c56b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1666 lines) Patch
M tracing/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
D tracing/build/d8_bootstrap.js View 1 chunk +0 lines, -284 lines 0 comments Download
D tracing/build/d8_runner.py View 1 chunk +0 lines, -231 lines 0 comments Download
D tracing/build/d8_runner_unittest.py View 1 chunk +0 lines, -493 lines 0 comments Download
D tracing/build/html_to_js_generator.js View 1 chunk +0 lines, -180 lines 0 comments Download
D tracing/build/path_utils.js View 1 chunk +0 lines, -110 lines 0 comments Download
D tracing/build/path_utils_test.html View 1 chunk +0 lines, -38 lines 0 comments Download
D tracing/build/path_utils_test.js View 1 chunk +0 lines, -59 lines 0 comments Download
D tracing/build/test_data/bar.js View 1 chunk +0 lines, -4 lines 0 comments Download
D tracing/build/test_data/dummy_test_file View 1 chunk +0 lines, -6 lines 0 comments Download
D tracing/build/test_data/error.js View 1 chunk +0 lines, -9 lines 0 comments Download
D tracing/build/test_data/error_stack_test.html View 1 chunk +0 lines, -26 lines 0 comments Download
D tracing/build/test_data/error_stack_test.js View 1 chunk +0 lines, -14 lines 0 comments Download
D tracing/build/test_data/foo.html View 1 chunk +0 lines, -41 lines 0 comments Download
D tracing/build/test_data/load_error.html View 1 chunk +0 lines, -26 lines 0 comments Download
D tracing/build/test_data/load_error_2.html View 1 chunk +0 lines, -26 lines 0 comments Download
D tracing/build/test_data/load_js_error.html View 1 chunk +0 lines, -25 lines 0 comments Download
D tracing/build/test_data/load_js_error_2.html View 1 chunk +0 lines, -24 lines 0 comments Download
D tracing/build/test_data/load_simple_html.html View 1 chunk +0 lines, -26 lines 0 comments Download
D tracing/build/test_data/load_simple_html.js View 1 chunk +0 lines, -5 lines 0 comments Download
D tracing/build/test_data/load_simple_js.js View 1 chunk +0 lines, -5 lines 0 comments Download
D tracing/build/test_data/print_file_content.js View 1 chunk +0 lines, -11 lines 0 comments Download
D tracing/build/test_data/quit_0_test.js View 1 chunk +0 lines, -4 lines 0 comments Download
D tracing/build/test_data/quit_1_test.js View 1 chunk +0 lines, -4 lines 0 comments Download
D tracing/build/test_data/quit_274_test.js View 1 chunk +0 lines, -4 lines 0 comments Download
D tracing/build/test_data/quit_42_test.js View 1 chunk +0 lines, -4 lines 0 comments Download
D tracing/build/test_data/simple.js View 1 chunk +0 lines, -4 lines 0 comments Download
M tracing/run_d8_tests View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/run_py_tests View 2 chunks +2 lines, -0 lines 0 comments Download
A tracing/third_party/vinn/run_test View 1 chunk +14 lines, -0 lines 0 comments Download
A tracing/third_party/vinn/vinn/__init__.py View 1 chunk +16 lines, -0 lines 0 comments Download
A + tracing/third_party/vinn/vinn/d8_bootstrap.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/d8_runner.py View 2 chunks +9 lines, -8 lines 0 comments Download
A + tracing/third_party/vinn/vinn/d8_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tracing/third_party/vinn/vinn/html_to_js_generator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/path_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/path_utils_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/path_utils_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/bar.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/dummy_test_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/error.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/error_stack_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/error_stack_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/foo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_error_2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_js_error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_js_error_2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_simple_html.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_simple_html.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/load_simple_js.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/print_file_content.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/quit_0_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/quit_1_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/quit_274_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/quit_42_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/third_party/vinn/vinn/test_data/simple.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M tracing/tracing_project.py View 2 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 4
nednguyen
8 years, 9 months ago (2015-07-24 22:53:13 UTC) #1
nduca(google)
lgtm btw, all you need is BUG=#1121 in your cl description
8 years, 9 months ago (2015-07-24 23:18:43 UTC) #2
nednguyen
Committed patchset #1 (id:1) manually as 10842fecce208811028980d626bec9bd7e77c56b (presubmit successful).
8 years, 9 months ago (2015-07-24 23:25:57 UTC) #3
nduca
8 years, 9 months ago (2015-07-29 04:55:07 UTC) #4
Message was sent while issue was closed. 
we have a stray print in d8_runner
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b