Issue 2524041: Only parse the lockedDomainSuffix when locked domain is enabled

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2524041: Only parse the lockedDomainSuffix when locked domain is enabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by chirag

Modified:
15 years, 5 months ago

Reviewers:
henry.saputra, dev-remailer, plindner1

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Simple change to only parse the lockedDomainSuffix in each container when gadgets.uri.iframe.lockedDomainRequired is set to true. This prevents RuntimeExceptions complaining about gadgets.uri.iframe.lockedDomainSuffix not having a value when the feature is lockedDomainRequired false.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages