Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(443)

Issue 251840044: Issue 4478: Disentangle some Tie and Semi_tie code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Dan Eble
Modified:
10 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Both are Grobs, but ties are Spanners and semi-ties are Items. The code for both cases was jumbled together in many Tie methods. I hope that I have clarified a few things. No functional changes are intended.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -87 lines) Patch
M lily/completion-note-heads-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/include/semi-tie.hh View 1 chunk +5 lines, -1 line 0 comments Download
M lily/include/tie.hh View 1 chunk +6 lines, -5 lines 0 comments Download
M lily/include/tie-column.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/semi-tie.cc View 2 chunks +22 lines, -4 lines 0 comments Download
M lily/tie.cc View 7 chunks +48 lines, -50 lines 1 comment Download
M lily/tie-column.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/tie-engraver.cc View 4 chunks +14 lines, -15 lines 0 comments Download
M lily/tie-formatting-problem.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M lily/tie-specification.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Dan Eble
10 years, 7 months ago (2015-07-04 01:47:27 UTC) #1
Dan Eble
https://codereview.appspot.com/251840044/diff/1/lily/tie.cc File lily/tie.cc (right): https://codereview.appspot.com/251840044/diff/1/lily/tie.cc#newcode128 lily/tie.cc:128: one_head = Semi_tie::head (item); Whoops. This should have been ...
10 years, 7 months ago (2015-07-12 00:27:14 UTC) #2
Dan Eble
On 2015/07/12 00:27:14, Dan Eble wrote: > lily/tie.cc:128: one_head = Semi_tie::head (item); > Whoops. This ...
10 years, 7 months ago (2015-07-12 12:22:16 UTC) #3
Dan Eble
10 years, 7 months ago (2015-07-14 11:38:05 UTC) #4
Message was sent while issue was closed.
The next spurt of work is in https://codereview.appspot.com/254090043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b