Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 251670043: Repair test breakage. Update RegExp whitelist. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by MarkM
Modified:
10 years, 7 months ago
Reviewers:
kpreid_google
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

While running the Caja regression tests ("ant runtests") the testOk test fails in test_GLOBAL_LEAKS_FROM_ARRAY_METHODS due to a bug on FF 39 we have yet to diagnose or report: When this code tries to define a global property to its current state, defineProperty throws an error. Since guest code cannot cause SES to attempt to defineProperty a global property, simply skipping the defineProperty in this case is safe. For several properties that were data properties on RegExp instances in ES5, ES6 (ECMAScript 2015) instead makes them accessor properties on RegExp.prototype. See the note at http://www.ecma-international.org/ecma-262/6.0/index.html#sec-properties-of-regexp-instances This CL updates the whitelist to reflect this change. Prior to this CL, this discrepancy was causing several test failures on FF 39.

Patch Set 1 #

Patch Set 2 : Repair test breakage. Update RegExp whitelist. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M src/com/google/caja/ses/repairES5.js View 1 1 chunk +24 lines, -3 lines 0 comments Download
M src/com/google/caja/ses/whitelist.js View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3
MarkM
10 years, 7 months ago (2015-08-06 04:25:05 UTC) #1
MarkM
While running the Caja regression tests ("ant runtests") the testOk test fails in test_GLOBAL_LEAKS_FROM_ARRAY_METHODS due ...
10 years, 7 months ago (2015-08-06 04:43:13 UTC) #2
kpreid_google
10 years, 7 months ago (2015-08-06 20:24:25 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b