Issue 2515043: code review 2515043: build: Allow archiver to be specified in the environmen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2515043: code review 2515043: build: Allow archiver to be specified in the environmen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by albert.strasheim

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

build: Allow archiver to be specified in the environment with HOST_AR.

Patch Set 1 #

Patch Set 2 : code review 2515043: build: Allow archiver (AR) to be specified in the envir... #

Total comments: 2

Patch Set 3 : code review 2515043: build: Allow archiver to be specified in the environmen... #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/Make.clib	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/Make.inc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

albert.strasheim

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-10-18 15:34:11 UTC) #1

rsc1

Seems like an okay thing to do, but not done right. Look at how other ...

14 years, 4 months ago (2010-11-01 20:39:33 UTC) #2

albert.strasheim

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 4 months ago (2010-11-02 08:50:40 UTC) #3

rsc

14 years, 3 months ago (2010-12-07 20:28:29 UTC) #5

*** Submitted as 6dcb0834cdf4 ***

build: Allow archiver to be specified in the environment with HOST_AR.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2515043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages