Issue 251400043: Fix extends docs for some tracks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 251400043: Fix extends docs for some tracks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dsinclair

Modified:
10 years, 9 months ago

Reviewers:
petrcermak

CC:
tracing-review_chromium.org

Base URL:
git@github.com:google/trace-viewer@master

Visibility:
Public.

More Reviews

Description

Fix extends docs for some tracks. These were incorrectly set to HeadingTrack. TBR=petrcermak@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/8a703bda01e95ea1020da5c4baf3b738071947f4

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tracing/tracing/ui/tracks/sample_track.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tracing/tracing/ui/tracks/slice_track.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dsinclair

Committed patchset #1 (id:1) manually as 8a703bda01e95ea1020da5c4baf3b738071947f4 (presubmit successful).

10 years, 9 months ago (2015-07-23 15:35:43 UTC) #1

Message was sent while issue was closed.

LGTM.

Thanks,
Petr

Expand All Messages | Collapse All Messages