Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 25066: refactoring about caching for php-shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by panjie.pan
Modified:
16 years, 6 months ago
Reviewers:
chabotc, shindig-dev, chabotc1
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/trunk/
Visibility:
Public.

Description

I found that there are a few problems when implementing limited invalidation: 1. fix unittest failed 2. fix SHINDIG-926 https://issues.apache.org/jira/browse/SHINDIG-926 3. current caching method put all data into one cache. I would like to adding name to distinguish each caches. For CacheFile, name is the directory of cache file. For CacheApc and CacheMemcache, name is the prefix of keys. New change: 1. We can't use Apc/Memcache's expiring method because we may need stale content. So I stored ttl for Apc/Memcache just like CacheFile. 2. Add invalidate for cache.

Patch Set 1 #

Patch Set 2 : updated and added unittest for class BasicRemoteContent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -1828 lines) Patch
php/src/common/Cache.php View 1 1 chunk +108 lines, -5 lines 0 comments Download
php/src/common/CacheStorage.php View 1 chunk +45 lines, -0 lines 0 comments Download
php/src/common/RemoteContent.php View 1 1 chunk +2 lines, -0 lines 0 comments Download
php/src/common/sample/BasicRemoteContent.php View 1 2 chunks +39 lines, -12 lines 0 comments Download
php/src/common/sample/CacheApc.php View 1 1 chunk +0 lines, -90 lines 0 comments Download
php/src/common/sample/CacheFile.php View 1 1 chunk +0 lines, -132 lines 0 comments Download
php/src/common/sample/CacheMemcache.php View 1 1 chunk +0 lines, -118 lines 0 comments Download
php/src/common/sample/CacheStorageApc.php View 1 chunk +61 lines, -0 lines 0 comments Download
php/src/common/sample/CacheStorageFile.php View 1 chunk +92 lines, -0 lines 0 comments Download
php/src/common/sample/CacheStorageMemcache.php View 1 chunk +73 lines, -0 lines 0 comments Download
php/src/gadgets/GadgetContext.php View 1 5 chunks +1 line, -18 lines 0 comments Download
php/src/gadgets/GadgetFactory.php View 1 1 chunk +1 line, -1 line 0 comments Download
php/src/gadgets/GadgetFeatureRegistry.php View 1 1 chunk +1 line, -2 lines 0 comments Download
php/src/gadgets/oauth/BasicGadgetOAuthTokenStore.php View 1 1 chunk +1 line, -2 lines 0 comments Download
php/src/gadgets/render/GadgetRenderer.php View 1 1 chunk +1 line, -2 lines 0 comments Download
php/src/social/converters/OutputAtomConverter.php View 1 1 chunk +1 line, -1 line 0 comments Download
php/src/social/converters/OutputXmlConverter.php View 1 1 chunk +1 line, -1 line 0 comments Download
php/test/TestContext.php View 1 chunk +1 line, -1 line 0 comments Download
php/test/common/BasicRemoteContentTest.php View 6 chunks +202 lines, -16 lines 0 comments Download
php/test/common/CacheFileTest.php View 1 1 chunk +81 lines, -33 lines 0 comments Download
php/test/common/CacheMemcacheTest.php View 1 chunk +129 lines, -0 lines 0 comments Download
php/test/common/UrlGeneratorTest.php View 1 1 chunk +0 lines, -86 lines 0 comments Download
php/test/gadgets/AuthTest.php View 1 1 chunk +0 lines, -56 lines 0 comments Download
php/test/gadgets/FeatureSpecTest.php View 1 1 chunk +0 lines, -70 lines 0 comments Download
php/test/gadgets/GadgetContextTest.php View 1 2 chunks +0 lines, -16 lines 0 comments Download
php/test/gadgets/GadgetFeatureRegistryTest.php View 1 1 chunk +0 lines, -36 lines 0 comments Download
php/test/gadgets/GadgetIdTest.php View 1 1 chunk +0 lines, -84 lines 0 comments Download
php/test/gadgets/GadgetServerTest.php View 1 1 chunk +0 lines, -144 lines 0 comments Download
php/test/gadgets/GadgetSpecParserTest.php View 1 3 chunks +4 lines, -4 lines 0 comments Download
php/test/gadgets/GadgetTest.php View 1 4 chunks +66 lines, -287 lines 0 comments Download
php/test/gadgets/HttpUtilTest.php View 1 1 chunk +0 lines, -60 lines 0 comments Download
php/test/gadgets/JsLibraryTest.php View 1 1 chunk +0 lines, -81 lines 0 comments Download
php/test/gadgets/LinkSpecTest.php View 1 1 chunk +0 lines, -74 lines 0 comments Download
php/test/gadgets/LocaleSpecTest.php View 1 1 chunk +0 lines, -78 lines 0 comments Download
php/test/gadgets/MessageBundleParserTest.php View 1 1 chunk +0 lines, -86 lines 0 comments Download
php/test/gadgets/MessageBundleTest.php View 1 1 chunk +0 lines, -62 lines 0 comments Download
php/test/gadgets/UserPrefsTest.php View 1 1 chunk +0 lines, -88 lines 0 comments Download
php/test/gadgets/ViewSpecTest.php View 1 1 chunk +0 lines, -75 lines 0 comments Download
php/test/social/OutputAtomConverterTest.php View 1 1 chunk +3 lines, -3 lines 0 comments Download
php/test/social/OutputJsonConverterTest.php View 1 1 chunk +1 line, -1 line 0 comments Download
php/test/social/OutputXmlConverterTest.php View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
panjie.pan
16 years, 11 months ago (2009-03-05 11:04:53 UTC) #1
panjie.pan
16 years, 11 months ago (2009-03-06 08:59:26 UTC) #2
updated and added unittest for class BasicRemoteContent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b