Add a ViewVC link to description when committing (as gcl does)

Add a ViewVC link to description when committing (as gcl does)

[mikhail.naganov, 2009-03-05 09:48:15]

This is it. I fixed the 80-column issue.

About making the ViewVC link a "soft requirement": if a project doesn't have a
ViewVC feature, then any string can be entered by a developer instead of URL
base, e.g. a "revision " string.

I'm experiencing the same problem with the tree status URL. For V8 currently
there's no such URL, so I mocked up a file that contains "tree is open" text in
order to satisfy git-cl.

I think that users of git-cl are smart enough in order to deal with this. Making
ViewVC URL optional makes it easy to forget about it.

Maybe we need to say "please run git cl config after updating this script" to
prevent user's confusion on commiting?

[evan, 2009-03-05 16:00:22]

On 2009/03/05 09:48:15, mikhail.naganov wrote:
> This is it. I fixed the 80-column issue.
> 
> About making the ViewVC link a "soft requirement": if a project doesn't have a
> ViewVC feature, then any string can be entered by a developer instead of URL
> base, e.g. a "revision " string.
> 
> I'm experiencing the same problem with the tree status URL. For V8 currently
> there's no such URL, so I mocked up a file that contains "tree is open" text
in
> order to satisfy git-cl.
> 
> I think that users of git-cl are smart enough in order to deal with this.
Making
> ViewVC URL optional makes it easy to forget about it.
> 
> Maybe we need to say "please run git cl config after updating this script" to
> prevent user's confusion on commiting?

The tree status URL thing is a bug.  I'm sorry you had to work around it.  :(  I
will fix it.

And I understand better: it's not that the URL is used, it's just the prefix
that's appended to the log message.  Maybe it should be more descriptive then? 
E.g. "log message note"?  Ugh, hard to explain.

Ok, third option -- we should pull this all from the origin site anyway:

$ svn cat http://src.chromium.org/svn/codereview.settings
# This file is used by gcl to get repository specific information.
CODE_REVIEW_SERVER: codereview.chromium.org
CC_LIST: chromium-reviews@googlegroups.com
VIEW_VC: http://src.chromium.org/viewvc/chrome?view=rev&revision=
STATUS: http://chromium-status.appspot.com/status
TRY_ON_UPLOAD: True

Then it matters less that it's called viewvc.

I just don't want this program to fail if you don't set a "viewvc url" because
most people don't even run viewvc.

[evan, 2009-03-05 16:03:36]

I just double-checked the code and it tries to make the tree status stuff
optional.  E.g., the comment is:
    # Check the tree status if the tree status URL is set.
Ah, but it was only fixed in commit 7221838485bd0d4a7d9955ef9596f05cab5676d8 ...
maybe you didn't have that version.

[mikhail.naganov, 2009-03-05 19:19:35]

Yes, sorry, it was my mistake to think that Tree URL is mandatory.

Fetching settings from repository is a very good idea. Right now I'm copying
them by hand.

[evan, 2009-03-10 20:37:38]

Something seems to have gone wrong in your diff -- it's only showing a few
lines.  Maybe you need to pass a base branch to diff against when uploading?