Issue 250600043: GSoC 2015 - Carrier Aggregation - Control Plane

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 250600043: GSoC 2015 - Carrier Aggregation - Control Plane

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by dabrignani

Modified:
9 years, 9 months ago

Reviewers:
Nicola Baldo, Marco Miozzo

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

This is code review request for GSoC 2015, LTE CA Support. This code review request is incremental with respect to the others that 2 I requested. It is related to the Lte Control Plane implementation. After the mid term evaluation I made a lot of changes in the architecture, details on wiki page https://www.nsnam.org/wiki/GSOC2015LTECA.

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1492 lines, -194 lines)			Patch
A	src/lte/doc/source/CarrierAggregationDownlinkDataPlane.seqdiag	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	src/lte/doc/source/figures/lte-arch-enb-ctrl-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-enb-data-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-ue-ctrl-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/figures/lte-arch-ue-data-carrier-aggregation.dia	View	Binary file		0 comments	Download
A	src/lte/doc/source/setupRadioBearerCarrierAggregation.seqdiag	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/lte/helper/lte-helper.h	View	4 chunks	+41 lines, -8 lines	0 comments	Download
M	src/lte/helper/lte-helper.cc	View	18 chunks	+153 lines, -83 lines	0 comments	Download
M	src/lte/helper/mac-stats-calculator.cc	View	4 chunks	+14 lines, -7 lines	0 comments	Download
M	src/lte/model/component-carrier-enb.h	View	2 chunks	+19 lines, -1 line	0 comments	Download
M	src/lte/model/component-carrier-enb.cc	View	4 chunks	+70 lines, -1 line	0 comments	Download
M	src/lte/model/component-carrier-ue.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/lte/model/component-carrier-ue.cc	View	4 chunks	+22 lines, -1 line	0 comments	Download
A	src/lte/model/lte-ccm-rrc-sap.h	View	1 chunk	+195 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ccm-rrc-sap.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-enb-component-carrier-manager.h	View	1 chunk	+115 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-enb-component-carrier-manager.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-enb-net-device.h	View	3 chunks	+17 lines, -6 lines	0 comments	Download
M	src/lte/model/lte-enb-net-device.cc	View	9 chunks	+27 lines, -10 lines	0 comments	Download
M	src/lte/model/lte-enb-rrc.h	View	7 chunks	+16 lines, -11 lines	0 comments	Download
M	src/lte/model/lte-enb-rrc.cc	View	21 chunks	+77 lines, -33 lines	0 comments	Download
A	src/lte/model/lte-ue-component-carrier-manager.h	View	1 chunk	+84 lines, -0 lines	0 comments	Download
A	src/lte/model/lte-ue-component-carrier-manager.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-ue-mac.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/lte/model/lte-ue-net-device.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/lte/model/lte-ue-rrc.h	View	7 chunks	+26 lines, -3 lines	0 comments	Download
M	src/lte/model/lte-ue-rrc.cc	View	15 chunks	+48 lines, -16 lines	0 comments	Download
A	src/lte/model/no-op-component-carrier-manager.h	View	1 chunk	+79 lines, -0 lines	0 comments	Download
A	src/lte/model/no-op-component-carrier-manager.cc	View	1 chunk	+98 lines, -0 lines	0 comments	Download
A	src/lte/model/simple-ue-component-carrier-manager.h	View	1 chunk	+79 lines, -0 lines	0 comments	Download
A	src/lte/model/simple-ue-component-carrier-manager.cc	View	1 chunk	+98 lines, -0 lines	0 comments	Download
M	src/lte/wscript	View	2 chunks	+10 lines, -7 lines	0 comments	Download