Issue 250590044: [perf_insights] Make sure all tags are alphanumeric

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 250590044: [perf_insights] Make sure all tags are alphanumeric (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by fmeawad

Modified:
8 years, 9 months ago

Reviewers:
dsinclair

CC:
tracing-review_chromium.org

Base URL:
https://github.com/google/trace-viewer.git@master

Visibility:
Public.

More Reviews

Description

[perf_insights] Make sure all tags are alphanumeric R=dsinclair@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/2cf812ba2015bfcc392a2f401c253850b31060c7

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	perf_insights/perf_insights/upload.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fmeawad

8 years, 9 months ago (2015-07-22 17:59:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2cf812ba2015bfcc392a2f401c253850b31060c7 (presubmit successful).

Expand All Messages | Collapse All Messages